Skip to content

Remove some dead code #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
henrymercer merged 2 commits into from
Nov 23, 2022
Merged

Remove some dead code #1390

henrymercer merged 2 commits into from
Nov 23, 2022

Conversation

@henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Nov 23, 2022

The Action requires GHES 3.3, so we can safely remove this fallback logic for GHES 2.22 and GHES 3.0.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner November 23, 2022 14:04
aeisenberg
aeisenberg reviewed Nov 23, 2022
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like GITHUB_ACTION_REPOSITORY is not being set during the integration tests. See:

https://github.com/github/codeql-action/actions/runs/3532744788/jobs/5927496032#step:4:14

@aeisenberg
Copy link
Contributor

aeisenberg commented Nov 23, 2022

Otherwise looks reasonable.

@henrymercer henrymercer force-pushed the henrymercer/remove-dead-code branch from d8597f3 to bc341c5 Compare November 23, 2022 18:19
@henrymercer
Copy link
Contributor Author

henrymercer commented Nov 23, 2022

So GITHUB_ACTION_REPOSITORY is only set when calling an Action from another repository. We still need to populate it manually if we're running locally.

I've updated the PR to only remove the code that deals with the fact that GHES 2.22 didn't populate GITHUB_ACTION_REPOSITORY even when the Action is called from anothe repository.

aeisenberg
aeisenberg approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming all jobs pass.

@henrymercer henrymercer merged commit 187515b into main Nov 23, 2022
@henrymercer henrymercer deleted the henrymercer/remove-dead-code branch November 23, 2022 18:55
This was referenced Nov 25, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henrymercer @aeisenberg