Use Swift version 5.7 in PR checks #1387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version installed in the latest runner image, 5.7.1, is not yet supported.
henrymercer
force-pushed
the
henrymercer/fix-swift-version
branch
from
fa52443 to
b6e17a6
Compare
aeisenberg
reviewed
Nov 22, 2022
angelapwen
previously approved these changes
Nov 22, 2022
Contributor
angelapwen
left a comment
angelapwen
left a comment
There was a problem hiding this comment.
✔️
I wonder if I should also include this step in the CodeQL Action integration test on the CLI-side (just adding the check for Swift here https://github.com/github/semmle-code/pull/44368/files#)
angelapwen
reviewed
Nov 22, 2022
Contributor
Author
👍 That makes sense to me |
angelapwen
previously approved these changes
Nov 22, 2022
angelapwen
approved these changes
Nov 22, 2022
This was referenced Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version installed in the latest runner image, 5.7.1, is not yet supported.
cc @AlexDenisov
Merge / deployment checklist