Skip to content

Add the CliConfigFileEnabled feature flag #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aeisenberg merged 3 commits into from
Sep 28, 2022
Merged

Add the CliConfigFileEnabled feature flag #1270

aeisenberg merged 3 commits into from
Sep 28, 2022

Conversation

@aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Sep 27, 2022

Also, wire it up to the useCodeScanningConfigInCli function.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner September 27, 2022 02:57
henrymercer
henrymercer previously approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

henrymercer
henrymercer reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there's a typo here

@aeisenberg
Copy link
Contributor Author

aeisenberg commented Sep 27, 2022

I'm going to add some unit tests.

@aeisenberg aeisenberg force-pushed the aeisenberg/cli-config-feature-flag branch from c72eb20 to 22bbeb8 Compare September 27, 2022 14:34
@aeisenberg
Add the CliConfigFileEnabled feature flag
e37b0d6 
Also, wire it up to the `useCodeScanningConfigInCli` function.
@aeisenberg aeisenberg force-pushed the aeisenberg/cli-config-feature-flag branch from 22bbeb8 to e37b0d6 Compare September 27, 2022 14:58
angelapwen
angelapwen reviewed Sep 27, 2022
View reviewed changes
aeisenberg
aeisenberg commented Sep 27, 2022
View reviewed changes
angelapwen
angelapwen previously approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😸

@angelapwen
Copy link
Contributor

angelapwen commented Sep 27, 2022

Autogenerated JS files are not up to date, but otherwise ✅

@aeisenberg aeisenberg force-pushed the aeisenberg/cli-config-feature-flag branch from 5cc1af9 to cab46c5 Compare September 27, 2022 22:49
@angelapwen
Copy link
Contributor

angelapwen commented Sep 27, 2022

I think the failures are related to the Go extraction feature flag I just enabled. I un-enabled it again and they should work on re-run.

@aeisenberg
Copy link
Contributor Author

aeisenberg commented Sep 28, 2022

Hmmm...required check Download and check debug artifacts is marked as "expected". I'm not sure why it's not running.

@angelapwen
Copy link
Contributor

angelapwen commented Sep 28, 2022

Hmmm...required check Download and check debug artifacts is marked as "expected". I'm not sure why it's not running.

I've seen this before. I think it's waiting on the upload jobs it depends on to finish, and then it will run.

@aeisenberg
Copy link
Contributor Author

aeisenberg commented Sep 28, 2022

Well...I merged with main and updated all required checks. Hopefully, this is enough to fix things. Yours may have been an easier solution.

@aeisenberg aeisenberg merged commit 74740ee into main Sep 28, 2022
@aeisenberg aeisenberg deleted the aeisenberg/cli-config-feature-flag branch September 28, 2022 19:43
This was referenced Sep 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrymercer henrymercer henrymercer left review comments

+1 more reviewer

@angelapwen angelapwen angelapwen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aeisenberg @angelapwen @henrymercer