Skip to content

Commit d92a91c

Browse files
aeisenbergaeisenberg
authored
Merge pull request #1218 from github/aeisenberg/move-pack-download-to-init
Move calls to pack download to the init action
2 parents a59fbe2 + 7294b40 commit d92a91c

File tree

10 files changed

+220
-30
lines changed

10 files changed

+220
-30
lines changed

‎CHANGELOG.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## [UNRELEASED]
44

5-
No user facing changes.
5+
- Downloading CodeQL packs has been moved to the `init` step. Previously, CodeQL packs were downloaded during the `analyze` step. [#1218](https://github.com/github/codeql-action/pull/1218)
66

77
## 2.1.21 - 25 Aug 2022
88

‎lib/analyze.js‎

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/analyze.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/config-utils.js‎

Lines changed: 30 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/config-utils.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/config-utils.test.js‎

Lines changed: 68 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/config-utils.test.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/analyze.ts‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -280,21 +280,6 @@ export async function runQueries(
280280
logger.endGroup();
281281
logger.info(analysisSummary);
282282
} else {
283-
if (hasPackWithCustomQueries) {
284-
logger.info("Performing analysis with custom CodeQL Packs.");
285-
logger.startGroup(`Downloading custom packs for ${language}`);
286-
287-
const results = await codeql.packDownload(packsWithVersion);
288-
289-
logger.info(
290-
`Downloaded packs: ${results.packs
291-
.map((r) => `${r.name}@${r.version || "latest"}`)
292-
.join(", ")}`
293-
);
294-
295-
logger.endGroup();
296-
}
297-
298283
logger.startGroup(`Running queries for ${language}`);
299284
const querySuitePaths: string[] = [];
300285
if (queries["builtin"].length > 0) {

0 commit comments

Comments
 (0)