Merged
Conversation
ghost
assigned
Member
|
Do you know if it still builds with VS2017? |
gerhardol
force-pushed
the
bugfix/vs2019-msbuild
branch
from
6719a4d to
fbe32c4
Compare
gerhardol
force-pushed
the
bugfix/vs2019-msbuild
branch
from
fbe32c4 to
82d021e
Compare
Member
Author
|
Awaiting discussions in upstream before removing WIP |
gerhardol
force-pushed
the
bugfix/vs2019-msbuild
branch
from
82d021e to
430e6a4
Compare
Codecov Report
@@ Coverage Diff @@
## master #6500 +/- ##
==========================================
+ Coverage 47.35% 47.35% +<.01%
==========================================
Files 705 705
Lines 52846 52847 +1
Branches 6955 6955
==========================================
+ Hits 25024 25025 +1
Misses 26497 26497
Partials 1325 1325
|
gerhardol
force-pushed
the
bugfix/vs2019-msbuild
branch
2 times, most recently
from
e444ec0 to
d389fe5
Compare
Merged
gerhardol
force-pushed
the
bugfix/vs2019-msbuild
branch
2 times, most recently
from
278095b to
6921f49
Compare
Updated hMSBuild to 2.1.0 from https://github.com/3F/hMSBuild/ Use 64bit build where possible Note: hMSBuild.bat is compressed/compiled compared to the "source" A later release may include hMSBuild.full.bat that is easier to debug
gerhardol
force-pushed
the
bugfix/vs2019-msbuild
branch
from
6921f49 to
2827bf4
Compare
Member
Author
|
hMSbuild 2.1.0 released |
RussKie
approved these changes
May 27, 2019
Member
|
do we need to update the appveyor script to target vs2019? |
Member
|
sorry, wrong button 😊 |
Member
Author
|
AppVeyor explicitly targets vs2017 now. When we raise the requirement to use vs2019 appveyor.yml must be updated too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Prepare to build with VS2019
Test methodology
Build from commandline
Test environment(s)
VS2019 installed in addition to VS2017
✒️ I contribute this code under The Developer Certificate of Origin.