Skip to content

Comments

fix faulty ordering in vendored notify debounce (#8026)#8094

Merged
krlvi merged 1 commit intomasterfrom
unknown repository
Apr 9, 2025
Merged

fix faulty ordering in vendored notify debounce (#8026)#8094
krlvi merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Apr 9, 2025

ported from upstream fix notify-rs/notify#638

🧢 Changes

Fix sorting of rename events

☕️ Reasoning

The problem was fixed upstream: notify-rs/notify#638

Fixes: #8026

@vercel
Copy link

vercel bot commented Apr 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 7:21pm

@vercel
Copy link

vercel bot commented Apr 9, 2025

@rhizoome is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the rust Pull requests that update Rust code label Apr 9, 2025
@ghost ghost changed the title fix faulty ordering in vendored notify (#8026) fix faulty ordering in vendored notify debounce (#8026) Apr 9, 2025
Copy link
Member

@krlvi krlvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rhizoome for taking the time to investigate this and backport the fix!

@krlvi krlvi merged commit 6433f25 into gitbutlerapp:master Apr 9, 2025
18 of 19 checks passed
@Byron
Copy link
Collaborator

Byron commented Apr 12, 2025

Yes, I can only second that, thanks so much!

This makes me want to unvendor our code actually - we did it for Windows, but in V3 there might actually not be a need for that anymore.
Probably something to keep in mind as we make progress.

@ghost ghost mentioned this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crashes during large builds inside a repository (notify-rs)

2 participants