Fix Signing#6069
Merged
Merged
Conversation
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
rust
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@Byron if the command has already been quoted, should we strip them out? For a short while the advice on discord and GH was to add them, but now they could be problematic? |
Collaborator
Author
|
The issue was that the command is now run as shell-command on Windows, which also means commands would need to be quoted to handle paths with spaces like |
krlvi
reviewed
Jan 24, 2025
krlvi
reviewed
Jan 24, 2025
krlvi
approved these changes
Jan 24, 2025
Byron
enabled auto-merge
January 24, 2025 09:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
main