Skip to content

Added go 1.5.1 to docker scripts (via binary distro) #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
technoweenie merged 1 commit into from
Sep 11, 2015
Merged

Added go 1.5.1 to docker scripts (via binary distro) #654

technoweenie merged 1 commit into from
Sep 11, 2015

Conversation

@andyneff
Copy link
Contributor

@andyneff andyneff commented Sep 11, 2015

Added GOLANG_VERSION to override golang version
Disabled dependecy checking when building packages to support external
golang
Changed DOCKER_LFS_BUILD_VERSION to default to master instead.

@andyneff
Added go 1.5.1 to docker scripts (via binary distro)
88430de 
Added GOLANG_VERSION to override golang version
Disabled dependecy checking when building packages to support external
golang
@technoweenie
Copy link
Contributor

technoweenie commented Sep 11, 2015

Seems to work!

$ tree repos
repos
├── centos
│   ├── 5
│   │   ├── RPMS
│   │   │   ├── i686
│   │   │   │   └── git-lfs-0.6.0-1.el5.i686.rpm
│   │   │   ├── noarch
│   │   │   │   └── git-lfs-repo-release-1-1.el5.noarch.rpm
│   │   │   ├── repodata
│   │   │   │   ├── filelists.xml.gz
│   │   │   │   ├── other.xml.gz
│   │   │   │   ├── primary.xml.gz
│   │   │   │   └── repomd.xml
│   │   │   └── x86_64
│   │   │       └── git-lfs-0.6.0-1.el5.x86_64.rpm
│   │   └── SRPMS
│   │       ├── git-lfs-0.6.0-1.el5.src.rpm
│   │       ├── git-lfs-repo-release-1-1.el5.src.rpm
│   │       └── repodata
│   │           ├── filelists.xml.gz
│   │           ├── other.xml.gz
│   │           ├── primary.xml.gz
│   │           └── repomd.xml
│   ├── 6
│   │   ├── RPMS
│   │   │   ├── i686
│   │   │   │   └── git-lfs-0.6.0-1.el6.i686.rpm
│   │   │   ├── noarch
│   │   │   │   └── git-lfs-repo-release-1-1.el6.noarch.rpm
│   │   │   ├── repodata
│   │   │   │   ├── 68068b2b21d67f5c264fad1d735268a8d472897e116af6fa057dc1d5633afdc2-primary.sqlite.bz2
│   │   │   │   ├── 7676ce116f94d0f32a12a16b9c966a3434d8cd96ca72b548fa919ba3268bb7c2-primary.xml.gz
│   │   │   │   ├── 8c6589f3a028690fe2d9f08846949a9b85114ec65f04c9053979f126cf1db488-other.sqlite.bz2
│   │   │   │   ├── b1772a39d531c7678aafe8afb21c1f7c951cdc331974c3d42949e94a128173b8-other.xml.gz
│   │   │   │   ├── c62c7241ee57870e67e93156f1166bd31db78551362738f0c6941fade0a9fb79-filelists.xml.gz
│   │   │   │   ├── e091e56f5b9dca6df4ccdf988998d6d9123b624010be22fa2c97d351708f6c89-filelists.sqlite.bz2
│   │   │   │   └── repomd.xml
│   │   │   └── x86_64
│   │   │       └── git-lfs-0.6.0-1.el6.x86_64.rpm
│   │   └── SRPMS
│   │       ├── git-lfs-0.6.0-1.el6.src.rpm
│   │       ├── git-lfs-repo-release-1-1.el6.src.rpm
│   │       └── repodata
│   │           ├── 713210d96e4b817d9094763252a419aaa338a7fb447644f083a1af754726b7fa-filelists.xml.gz
│   │           ├── 7d661fd246aaac7cf8102e4a97deb4c6dd6ce2a5885a771a1fcdc647f692dad6-primary.sqlite.bz2
│   │           ├── 91809f5a101b772d275f0a6c94c29bf7685b43321b23a338911aa1de353d79d8-other.sqlite.bz2
│   │           ├── dc2b2d287ea03613cc77d94ff93ad93e2e1fec73358b30eda1d55003e484aa6e-other.xml.gz
│   │           ├── e79c55305bb02371e345aae490ef471c29da4ebc1db99915d8d166d43eddbb90-filelists.sqlite.bz2
│   │           ├── f27507411468edb6d04e3c051e874c7d91b3645a6f0afc4004023c27fdc0a1e7-primary.xml.gz
│   │           └── repomd.xml
│   └── 7
│       ├── RPMS
│       │   ├── i686
│       │   │   └── git-lfs-0.6.0-1.el7.i686.rpm
│       │   ├── noarch
│       │   │   └── git-lfs-repo-release-1-1.el7.noarch.rpm
│       │   ├── repodata
│       │   │   ├── 3702864cb7284a1411ab691d54a369dc21ff6f2ae2d07579cb2c3955bf13f3bf-primary.xml.gz
│       │   │   ├── 907a20e7a52cec6af670a570a4e3727acdb5e7ce4b324e44c652404d1d868f97-other.xml.gz
│       │   │   ├── 98b74385c3f2e5971aff8e87ff63381314b1792862eac40f9207143d3dd42ffd-filelists.sqlite.bz2
│       │   │   ├── a2fdff39be032ab0553877ecc7f0e9815ecf02ede5a61ee49d324eeb93f62e1a-primary.sqlite.bz2
│       │   │   ├── baeac0e3b49008d9289115e743c2056a8908e804c8e0d4da82b60da67bed90e1-other.sqlite.bz2
│       │   │   ├── e4e42ee5e08acd1f8a34965feb2dfeb63d340afb9e8cd9c38ddf6113590f95d3-filelists.xml.gz
│       │   │   └── repomd.xml
│       │   └── x86_64
│       │       └── git-lfs-0.6.0-1.el7.x86_64.rpm
│       └── SRPMS
│           ├── git-lfs-0.6.0-1.el7.src.rpm
│           ├── git-lfs-repo-release-1-1.el7.src.rpm
│           └── repodata
│               ├── 45162e51c4bf2022abfbfa188829b56cbba44e0d2adad551b7cafa369eddc92c-other.xml.gz
│               ├── 5cef31a50304c696b49f236ca6c2ae2e4d43511438ec88b71fb101abdf854ee8-filelists.xml.gz
│               ├── 69456067525a11116d3d95b293bccf48c7167dbca66451a48f2d2f78671d1a14-primary.sqlite.bz2
│               ├── 7c6824b066e1deefdfbf231ea4205678a745b0cdf8a0cd5b0a1a764a34fc582b-filelists.sqlite.bz2
│               ├── 821549ea061234240eedfcf9525a58c56fadb0a70703dd5961fe456a7f9e2879-primary.xml.gz
│               ├── ab3cbf320aec12e22a7b98069f40a8fc0449114d9a094532ce2dc3bbf5dbe3d5-other.sqlite.bz2
│               └── repomd.xml
└── debian
    ├── 7
    │   ├── conf
    │   │   └── distributions
    │   ├── db
    │   │   ├── checksums.db
    │   │   ├── contents.cache.db
    │   │   ├── packages.db
    │   │   ├── references.db
    │   │   ├── release.caches.db
    │   │   └── version
    │   ├── dists
    │   │   └── wheezy
    │   │       ├── Release
    │   │       └── main
    │   │           ├── binary-amd64
    │   │           │   ├── Packages
    │   │           │   ├── Packages.gz
    │   │           │   └── Release
    │   │           ├── binary-i386
    │   │           │   ├── Packages
    │   │           │   ├── Packages.gz
    │   │           │   └── Release
    │   │           └── source
    │   │               ├── Release
    │   │               └── Sources.gz
    │   └── pool
    │       └── main
    │           └── g
    │               └── git-lfs
    │                   ├── git-lfs_0.6.0.dsc
    │                   ├── git-lfs_0.6.0.tar.gz
    │                   ├── git-lfs_0.6.0_amd64.deb
    │                   └── git-lfs_0.6.0_i386.deb
    └── 8
        ├── conf
        │   └── distributions
        ├── db
        │   ├── checksums.db
        │   ├── contents.cache.db
        │   ├── packages.db
        │   ├── references.db
        │   ├── release.caches.db
        │   └── version
        ├── dists
        │   └── jessie
        │       ├── Release
        │       └── main
        │           ├── binary-amd64
        │           │   ├── Packages
        │           │   ├── Packages.gz
        │           │   └── Release
        │           ├── binary-i386
        │           │   ├── Packages
        │           │   ├── Packages.gz
        │           │   └── Release
        │           └── source
        │               ├── Release
        │               └── Sources.gz
        └── pool
            └── main
                └── g
                    └── git-lfs
                        ├── git-lfs_0.6.0.dsc
                        ├── git-lfs_0.6.0.tar.xz
                        ├── git-lfs_0.6.0_amd64.deb
                        └── git-lfs_0.6.0_i386.deb

52 directories, 91 files

technoweenie added a commit that referenced this pull request Sep 11, 2015
@technoweenie
Merge pull request #654 from andyneff/docker_golang_update
684898b 
Added go 1.5.1 to docker scripts (via binary distro)
@technoweenie technoweenie merged commit 684898b into git-lfs:master Sep 11, 2015
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request Dec 27, 2022
@chrisd8088
rpm/build_rpms.bsh: drop CentOS 5/6 Go install
6de6f8e 
Since the original introduction of the rpm/build_rpms.bsh script in
commit 4a71627 of PR git-lfs#332 it has
checked for the absence of the "go" binary and, if it is not found,
installs the golang package, except on CentOS 5 where fetches and
patches a golang.spec file and then builds a local RPM using that
in order to install Go.

However, in commit b560b85 of PR git-lfs#1298 and
in commit git-lfs/build-dockers@64a3a9f of
PR git-lfs/build-dockers#3 we dropped support for CentOS 5.

And in commit 88430de of PR git-lfs#654 we
updated our CentOS Dockerfiles (before they were moved to the
git-lfs/build-dockers repository) to download and install Go from the
googleapis.com service, and we still continue to do this but as of
commit git-lfs/build-dockers@c638503
in PR git-lfs/build-dockers#35 we now use the golang.org service.

This direct download obviates the logic in our rpm/build_rpms.bsh
script to install the golang package, and the special handling for
CentOS 5 is also obsolete, so we remove this logic from our script.
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request Dec 27, 2022
@chrisd8088
rpm/build_rpms.bsh: drop CentOS 5/6 Go install
e96f2c9 
Since the original introduction of the rpm/build_rpms.bsh script in
commit 4a71627 of PR git-lfs#332 it has
checked for the absence of the "go" binary and, if it is not found,
installs the golang package, except on CentOS 5 where fetches and
patches a golang.spec file and then builds a local RPM using that
in order to install Go.

However, in commit b560b85 of PR git-lfs#1298 and
in commit git-lfs/build-dockers@64a3a9f of
PR git-lfs/build-dockers#3 we dropped support for CentOS 5.

And in commit 88430de of PR git-lfs#654 we
updated our CentOS Dockerfiles (before they were moved to the
git-lfs/build-dockers repository) to download and install Go from the
googleapis.com service, and we still continue to do this but as of
commit git-lfs/build-dockers@c638503
in PR git-lfs/build-dockers#35 we now use the golang.org service.

This direct download obviates the logic in our rpm/build_rpms.bsh
script to install the golang package, and the special handling for
CentOS 5 is also obsolete, so we remove this logic from our script.
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request Dec 28, 2022
@chrisd8088
rpm/build_rpms.bsh: drop CentOS 5/6 Go install
60dafc2 
Since the original introduction of the rpm/build_rpms.bsh script in
commit 4a71627 of PR git-lfs#332 it has
checked for the absence of the "go" binary and, if it is not found,
installs the golang package, except on CentOS 5 where fetches and
patches a golang.spec file and then builds a local RPM using that
in order to install Go.

However, in commit b560b85 of PR git-lfs#1298 and
in commit git-lfs/build-dockers@64a3a9f of
PR git-lfs/build-dockers#3 we dropped support for CentOS 5.

And in commit 88430de of PR git-lfs#654 we
updated our CentOS Dockerfiles (before they were moved to the
git-lfs/build-dockers repository) to download and install Go from the
googleapis.com service, and we still continue to do this but as of
commit git-lfs/build-dockers@c638503
in PR git-lfs/build-dockers#35 we now use the golang.org service.

This direct download obviates the logic in our rpm/build_rpms.bsh
script to install the golang package, and the special handling for
CentOS 5 is also obsolete, so we remove this logic from our script.
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request Dec 28, 2022
@chrisd8088
rpm/build_rpms.bsh: drop unused NODEPS variable
03c4452 
In commit e2f770c of PR git-lfs#428
the rpm/build_rpms.bsh script was updated to run the rpmbuild command
with the --nodeps option when the NODEPS environment variable was defined
and set non-zero.

However, in commit 88430de of PR git-lfs#654
the script was revised to always pass the --nodeps option to the
rpmbuild command, so the NODEPS environment variable no longer had
any effect, and so We can therefore remove our handling of this variable.
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request Dec 28, 2022
@chrisd8088
rpm/build_rpms.bsh: drop unused NODEPS variable
47644a6 
In commit e2f770c of PR git-lfs#428
the rpm/build_rpms.bsh script was updated to run the rpmbuild command
with the --nodeps option when the NODEPS environment variable was defined
and set non-zero.

However, in commit 88430de of PR git-lfs#654
the script was revised to always pass the --nodeps option to the
rpmbuild command, so the NODEPS environment variable no longer had
any effect, and so We can therefore remove our handling of this variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andyneff @technoweenie