use direct value nil for error #6024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisd8088
approved these changes
Apr 1, 2025
Member
chrisd8088
left a comment
chrisd8088
left a comment
There was a problem hiding this comment.
Hey, thanks for this PR and bit of code cleanup!
As you noted, the value of err here must always be nil, since the preceding conditional checks for a non-nil value and returns early in that case. So this change has no functional impact but definitely makes our code a bit simpler and easier to understand.
Thanks again for this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the code logic I think,
if file not exists( statErr != nil ) it will be delay write to path use the
ptr, so it should call with a direct nil value.