Update license copyright dates and minimum supported Git version #5921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We last updated our software license in commit 4da6d5f of PR git-lfs#4513 to revise the current year in our copyright statement to 2021. As this date is now several years in the past, and because we want to avoid having to update our license each year, we simply remove the current year from our license's copyright statement now. This practice is in keeping with the format we use in the license files of all our other Git LFS projects, such as in the git-lfs/gitobj and git-lfs/pktline repositories. It also aligns with the practice of other major open-source projects, like that of the source code for the Go language and standard library. As well, we add a copyright date of 2009 to the Go project's license that we include in our main LICENSE.md, alongside the existing 2010 copyright date. When we first appended the Go project's license to our license file, in commit 74d5f2397f9abe4834bf1fe1fa02fd6c141b77cea, it was specifically due to the inclusion of some code into our "subprocess" package from the Go library's "os/exec" package. Those original source files have copyright dates of 2010, which is why we used that date in our copy of the Go project's license. For reference, see: https://github.com/golang/go/blob/b68f8ca89a2fb6b33d1e78fadc33d1c35693f6b8/src/os/exec/lp_unix.go#L1 https://github.com/golang/go/blob/b68f8ca89a2fb6b33d1e78fadc33d1c35693f6b8/src/os/exec/lp_windows.go#L1 In commit a662740 of PR git-lfs#4418 we then revised our license file to note that we also include some code from the Go library's "os" package in our "tools" package. The Go source code in this case has a copyright date of 2009, but we did not update our license file to reflect this, so we do that now. For reference, see: https://github.com/golang/go/blob/b68f8ca89a2fb6b33d1e78fadc33d1c35693f6b8/src/os/file_windows.go#L1 Finally, in commit fc95175 of PR git-lfs#4903 we removed our "vendor" directory and all the associated copies of our dependencies from this project. Our license file still mentions this directory, though, so we remove that reference now.
Our README file contains a brief note in its "Example Usage" section stating that Git LFS requires a Git version higher than 1.8.2 on Linux and 1.8.5 on macOS. This statement dates from commit 59a49b0 in PR git-lfs#412 in 2015, and so is relatively out of date. In particular, when we added support for the "git lfs migrate" command in PR git-lfs#2353, the actual minimum supported version of Git was changed from 1.8.x to 1.9.0 (in commit 1d0e834) and then to 2.0.0 (in commit 5aea841). These changes were made to the Travis CI configuration in use at the time, and later migrated to our current GitHub Actions CI workflow in commit c32820806229c3f42364d989f7a8597f73cb107ba of PR git-lfs#3808. This workflow continues to run our Git LFS test suite using Git 2.0.0. We therefore now update our README file to remove the outdated note about Git 1.8.x versions, and add a paragraph to the "Limitations" section which documents the current minimum supported Git version of 2.0.0 but also strongly advises the use of a more recent Git version.
larsxschneider
approved these changes
Dec 2, 2024
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Apr 3, 2025
Since commit a343a11 of PR git-lfs#1461, a number of our commands, including "git lfs pull", "git lfs push", and "git lfs track", have checked the version of the currently available Git program and reported an error if it was not at least version 1.8.2. However, when we added support for the "git lfs migrate" command in PR git-lfs#2353, the actual minimum supported version of Git was changed from 1.8.x to 1.9.0 (in commit 1d0e834) and then to 2.0.0 (in commit 5aea841). These changes were made to the Travis CI configuration in use at the time, and later migrated to our current GitHub Actions CI workflow in commit c32820806229c3f42364d989f7a8597f73cb107ba of PR git-lfs#3808. This workflow continues to run our Git LFS test suite using Git 2.0.0. More recently, in commit 1501265 of PR git-lfs#5921, we updated our README file to document that the current minimum supported version of Git we require is v2.0.0. We therefore now update the minimum Git version required by the Git LFS client to 2.0.0 by adjusting the version string defined in the requireGitVersion() function of our "commands" package.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Apr 3, 2025
Since commit a343a11 of PR git-lfs#1461, a number of our commands, including "git lfs pull", "git lfs push", and "git lfs track", have checked the version of the currently available Git program and reported an error if it was not at least version 1.8.2. However, when we added support for the "git lfs migrate" command in PR git-lfs#2353, the actual minimum supported version of Git was changed from 1.8.x to 1.9.0 (in commit 1d0e834) and then to 2.0.0 (in commit 5aea841). These changes were made to the Travis CI configuration in use at the time, and later migrated to our current GitHub Actions CI workflow in commit c32820806229c3f42364d989f7a8597f73cb107ba of PR git-lfs#3808. This workflow continues to run our Git LFS test suite using Git 2.0.0. More recently, in commit 1501265 of PR git-lfs#5921, we updated our README file to document that the current minimum supported version of Git we require is v2.0.0. We therefore now update the minimum Git version required by the Git LFS client to 2.0.0 by adjusting the version string defined in the requireGitVersion() function of our "commands" package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the copyright statement in our
LICENSE.mdfile to bring its format into line with that of our other Git LFS projects' licenses, by removing the current year from the statement. This also aligns with the practice of other major open-source software projects, such as the copyright statement for the Go language and standard library, and will avoid the necessity that we update our copyright statement every year.As well, we add the year 2009 to the copyright statement for the Go language project in our
LICENSE.mdfile, as the portions of that project's source code we incorporate into ourtoolspackage have a copyright date of 2009. (We also incorporate some portions of the Go standard library whose source files have a copyright date of 2010, so we leave that date in place.)Further, because we stopped using a
vendordirectory with copies of our dependencies in PR #4903, we remove the [reference](https://github.com/git-lfs/git-lfs/blob/6340befc60876f4f039f215479d9d5a945f817e1/LICENSE.md?plain=1#L54] to that directory from ourLICENSE.mdfile.Lastly, we also update our
README.mdfile to remove an outdated note regarding the minimum versions of Git required by Git LFS, and expand the "Limitations" section in that file to clarify that the current minimum Git version required by Git LFS is Git v2.0.0 (as is verified by our GitHub ActionsBuild with earliest GitCI job).