Upgrade to Go 1.23 #5872
Merged
Upgrade to Go 1.23 #5872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 21, 2024
Go version 1.23 has been released, and because we aim to build and test Git LFS against only supported versions of Go, we upgrade our GitHub Actions CI workflows to test against Go versions 1.23 and 1.22. This resolves a problem now seen in our "Build with specific Go" CI job, where we install the latest version of the "goimports" package and it fails because the "x/tools" module requires Go 1.22 as of commit golang/tools@70f5626, and we are still using Go 1.21 for that CI job.
chrisd8088
force-pushed
the
upgrade-go-1-23
branch
from
3c6d0e7 to
f437bb3
Compare
larsxschneider
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go version 1.23 has been released, and because we aim to build and test Git LFS against only supported versions of Go, we upgrade our GitHub Actions CI workflows to test against Go versions 1.23 and 1.22.
This resolves a problem now seen in our
Build with specific GoCI job, where we install the latest version of thegoimportspackage and it fails because thex/toolsmodule requires Go 1.22 as of commit golang/tools@70f5626, and we are still using Go 1.21 for that CI job.After this PR is merged, we will revise the required set of jobs in our CI test suite, and also upgrade the version of Go used in the scripts and Dockerfiles in our
github/build-dockersproject in PR git-lfs/build-dockers#68.The changes from this PR and PR git-lfs/build-dockers#68 have been tested successfully together using a full run of our CI suite in a private repository.