Provide loong64 Binary Support #5607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk2204
reviewed
Jan 3, 2024
Member
bk2204
left a comment
bk2204
left a comment
There was a problem hiding this comment.
Mostly this looks like it's heading in the right direction, but there are a few changes we need to add on here.
script/upload's categorize_arch needs to learn about this (it should probably be “64-bit LoongArch”), as does docs/howto/release-git-lfs.md. In general, everywhere you see ppc64le, a similar change should be provided as well.
qiangxuhui
force-pushed
the
main
branch
2 times, most recently
from
86fee76 to
d61b3ea
Compare
Contributor
Author
|
@bk2204 I made some modifications based on your comments. |
bk2204
approved these changes
Jan 4, 2024
Member
bk2204
left a comment
bk2204
left a comment
There was a problem hiding this comment.
Thanks for the patch! This looks good, and I'll merge it.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Nov 23, 2024
In commit d61b3ea of PR git-lfs#5607 we added support in our Makefile and scripts to build and upload a version of our Linux release assets for the LoongArch64 platform, and at the same time we added an entry for this platform to the end of the list of Linux assets in our release process documentation. Before updating the documentation of our release process, we first reorder this list to keep it in alphanumeric order, so as to match how assets are listed in our public release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go-1.19 has added support for loong64 arch, this PR adds build support for loong64 arch.
Building
Testing