Skip to content

Conversation

@nfgferreira
Copy link
Contributor

@nfgferreira nfgferreira commented Jul 20, 2023

Removing user.Current() from currentUser func() in tools/filetools.go. The reason: such call was not necessary and depending on the OS configuration could take more than 20 seconds to execute in Windows 10 due most likely to slow server response.

Fixes #5421.

@nfgferreira nfgferreira requested a review from a team as a code owner July 20, 2023 16:05
Copy link
Member

@bk2204 bk2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. This seems like a reasonable way to go about fixing the problem. Once CI is green, we can merge this.

@nfgferreira
Copy link
Contributor Author

My pleasure. Brian. Thanks for the support.

@chrisd8088 chrisd8088 changed the title git-lfs track very slow on Windows #5421 Resolve git-lfs track slowness on Windows due to unneeded user lookup Jul 20, 2023
@chrisd8088 chrisd8088 merged commit 05c1f17 into git-lfs:main Jul 20, 2023
@harrismine
Copy link

8994edd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git-lfs track very slow on Windows

4 participants