-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix missing parameter in git lfs logs manual page
#5414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR git-lfs#5054 we converted our manual pages to the AsciiDoc format, and in doing so, one entry in the manual page for the "git lfs logs" command lost the relevant "<file>" option parameter, so we restore it now.
bk2204
approved these changes
Jul 4, 2023
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
May 15, 2025
When we converted our manual page source files from the Ronn format to the AsciiDoc format in commit 0c66dcf of PR git-lfs#5054, a few terms were accidentally dropped if they were delimited with angle brackets but not also enclosed with backtick characters. In commit 219518e of PR git-lfs#5414 we restored one such missing term in the git-lfs-logs(1) manual page. We now restore another missing term, this time in the description section of the git-lfs-checkout(1) manual page, where the "<glob-pattern>" term was accidentally removed. We also take the opportunity to rephrase the sentence containing this term slightly so as to avoid the use of a trailing plural "s" character, as that causes formatting errors when rendering the AsciiDoc source into HTML or roff.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
May 15, 2025
When we converted our manual page source files from the Ronn format to the AsciiDoc format in commit 0c66dcf of PR git-lfs#5054, a few terms were accidentally dropped if they were delimited with angle brackets but not also enclosed with backtick characters. In commit 219518e of PR git-lfs#5414 we restored one such missing term in the git-lfs-logs(1) manual page, and in a prior commit in this PR we restored another in the git-lfs-checkout(1) manual page. We now restore another missing term, this time in the git-lfs-config(5) manual page, in the entry for the "lfs.customtransfer.<name>.path" configuration option, where the "<name>" term was accidentally removed from a sentence in which it was the first word. We also take the opportunity to add a leading definite article to the sentence so to make it slightly more idiomatic and readable.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
May 15, 2025
When we converted our manual page source files from the Ronn format to the AsciiDoc format in commit 0c66dcf of PR git-lfs#5054, a few terms were accidentally dropped if they were delimited with angle brackets but not also enclosed with backtick characters. In commit 219518e of PR git-lfs#5414 we restored one such missing term in the git-lfs-logs(1) manual page, and in prior commits in this PR we restored several others in the git-lfs-checkout(1) and git-lfs-config(5) manual pages. We now restore another missing term, this time in the description section of the git-lfs-smudge(1) manual page, where the "<path>" term was removed from the sentence which explained the purpose of the "git lfs smudge" command's optional progress log file path argument.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Nov 6, 2025
When we converted our manual page source files from the Ronn format to the AsciiDoc format in commit 0c66dcf of PR git-lfs#5054, a few terms were accidentally dropped if they were delimited with angle brackets but not also enclosed with backtick characters. In commit 219518e of PR git-lfs#5414 we restored one such missing term in the git-lfs-logs(1) manual page. We now restore another missing term, this time in the description section of the git-lfs-checkout(1) manual page, where the "<glob-pattern>" term was accidentally removed. We also take the opportunity to rephrase the sentence containing this term slightly so as to avoid the use of a trailing plural "s" character, as that causes formatting errors when rendering the AsciiDoc source into HTML or roff.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Nov 6, 2025
When we converted our manual page source files from the Ronn format to the AsciiDoc format in commit 0c66dcf of PR git-lfs#5054, a few terms were accidentally dropped if they were delimited with angle brackets but not also enclosed with backtick characters. In commit 219518e of PR git-lfs#5414 we restored one such missing term in the git-lfs-logs(1) manual page, and in a prior commit in this PR we restored another in the git-lfs-checkout(1) manual page. We now restore another missing term, this time in the git-lfs-config(5) manual page, in the entry for the "lfs.customtransfer.<name>.path" configuration option, where the "<name>" term was accidentally removed from a sentence in which it was the first word. We also take the opportunity to add a leading definite article to the sentence so to make it slightly more idiomatic and readable.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Nov 6, 2025
When we converted our manual page source files from the Ronn format to the AsciiDoc format in commit 0c66dcf of PR git-lfs#5054, a few terms were accidentally dropped if they were delimited with angle brackets but not also enclosed with backtick characters. In commit 219518e of PR git-lfs#5414 we restored one such missing term in the git-lfs-logs(1) manual page, and in prior commits in this PR we restored several others in the git-lfs-checkout(1) and git-lfs-config(5) manual pages. We now restore another missing term, this time in the description section of the git-lfs-smudge(1) manual page, where the "<path>" term was removed from the sentence which explained the purpose of the "git lfs smudge" command's optional progress log file path argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #5054 we converted our manual pages to the AsciiDoc format, and in doing so, one entry in the manual page for the
git-lfs-logs(1)command lost the relevant<file>option parameter from the ronn version, so we restore it now.