Avoid needlessly spawning SSH connections with git archive
#5309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user invokes
git archivewith LFS files,git lfs filter-processis invoked to smudge the LFS files. However, currently when we instantiate the manifest object as part of that, an attempt is made to connect to the remote using SSH, which we don't want to do unless necessary. For example, if the user already has all the files locally, the network connection is needless and serves only to waste resources.Adjust our manifest types to introduce a lazy manifest that only spawns the SSH connection on demand. Further description is available in the commit messages.
Fixes #5307