fix(tq): stop adding transfers to queue after abort #5230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the transfer gets aborted, dangling goroutines might add more transfers to the queue resulting in a wait deadlock. Conditionally add transfers to queue if abort flag is not set. Signed-off-by: Ayman Bagabas <[email protected]>
Member
|
Thanks for the patch! This looks reasonable to me, so I'm going to merge it. While looking at this I realize it would be nice to have some tests for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the transfer gets aborted, dangling goroutines might add more transfers to the queue resulting in a wait deadlock.
Conditionally add transfers to queue if abort flag is not set.
Using a pure-SSH approach makes the client hang unable to abort.
Signed-off-by: Ayman Bagabas [email protected]