Skip to content

Conversation

@bk2204
Copy link
Member

@bk2204 bk2204 commented Nov 10, 2022

We've recently some some problems where Jenkins sets core.hooksPath to an invalid value (on Windows, notably this is NUL:). Let's address this with a FAQ entry to explain how to work around that if necessary.

Also, in the course of writing this, it's been noted that the --skip-repo option is confusing with regards to --local. These options are orthogonal and can be used together, so indicate that and update the documentation to better describe what the --skip-repo option does and how it can be used.

Fixes #5171

@Gabzygreen11
Copy link

Bin

@Gabzygreen11
Copy link

2_Checkout.txt

@Gabzygreen11
Copy link

Bin

@bk2204 bk2204 marked this pull request as ready for review November 28, 2022 16:45
@bk2204 bk2204 requested a review from a team as a code owner November 28, 2022 16:45
+
Note that this prevents things like `git push` from pushing LFS objects and
locked files from being read only, since those are implemented by hooks. If you
need that functionality, you should contact the Jenkins documentation about how
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's just me, but "contact" here feels slightly off (I suppose because documentation is inert). Perhaps "review"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. I originally said "contact the Jenkins project" or somesuch and failed to fix the verb.

The name of the `--skip-repo` option leads people to believe that it's
incompatible with `--local`.  Let's describe the option more accurately
so that people know exactly what it does.  Don't specifically mention
the global LFS filters because one can indeed use local LFS filters with
it as well.  Capitalize "LFS", and specifically mention that any of the
destination options may be used in conjunction with this option.
We've had several different reports about a Jenkins configuration change
that intentionally provides an invalid hook path..  Document this in the
FAQ to help people find a solution to this problem.
@bk2204 bk2204 merged commit 13e6543 into git-lfs:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jenkins security disable core.hookPath cause git lfs install failed

3 participants