ssh: don't leak resources when falling back to legacy protocol #5137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we attempt a connection with the pure SSH protocol but fail, we fail to close the file descriptors for the pipes or reap the process which has exited. This can cause substantial resource consumption and run the user out of file descriptors or processes. Since that's not very nice, let's be sure to explicitly close the pipes and wait for the process if this occurs, which it probably will quite frequently, since few people are using the new pure SSH protocol.
chrisd8088
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we attempt a connection with the pure SSH protocol but fail, we fail to close the file descriptors for the pipes or reap the process which has exited. This can cause substantial resource consumption and run the user out of file descriptors or processes.
Since that's not very nice, let's be sure to explicitly close the pipes and wait for the process if this occurs, which it probably will quite frequently, since few people are using the new pure SSH protocol.
Fixes #5077