tools: don't match MINGW as Cygwin #5106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cygpath binary from Git for Windows has a bug: when the path contains braces, apostrophes, or certain other special characters, it strips them out when called from Go, but not from the command line. This results in us having broken behaviour with those characters in the current working directory. To address this, no longer consider MINGW to be a Cygwin-like environment.
In our shell script tests, we can end up with paths that start with things like "/tmp", which on Windows is implicitly rewritten into a real Windows path by the shell. However, when using the `urlify` function, that doesn't happen and therefore Git LFS gets a path it cannot handle. We used to paper over this by calling `cygpath -w` on all the paths we were given, but the version of `cygpath` shipped with Git for Windows is subtly broken and we don't want to rely on it anymore, so instead make our `urlify` helper convert to a canonical native path and then prefix with a slash if need be. Similarly, use the `urlify` helper in the multiple remotes test to make sure that the paths are rewritten properly.
chrisd8088
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cygpath binary from Git for Windows has a bug: when the path contains braces, apostrophes, or certain other special characters, it strips them out when called from Go, but not from the command line.
This results in us having broken behaviour with those characters in the current working directory. To address this, no longer consider MINGW to be a Cygwin-like environment.
Fixes #5105
Fixes #4829