installer: handle BashOnly Git for Windows gracefully
#5048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisd8088
reviewed
Jun 20, 2022
Member
chrisd8088
left a comment
chrisd8088
left a comment
There was a problem hiding this comment.
Thanks for this! I had one comment so far, and I'll give it a try later on a fresh Windows VM (once I remember how to tinker with the installer again!)
chrisd8088
reviewed
Jun 22, 2022
Member
chrisd8088
left a comment
chrisd8088
left a comment
There was a problem hiding this comment.
I've run a first test and found one thing I think needs to be resolved -- let me know if you agree.
It was reported in git-lfs#5031 that Git LFS' installer aborts because it does not find the `git` executable when Git for Windows was installed with the "Bash Only" PATH option, i.e. in the mode where `PATH` is not modified at all. Detect this situation, and fall back to implicitly extend the `PATH` to find Git for Windows' `git.exe`. Co-authored-by: Chris Darroch <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
handle-BashOnly-Git-for-Windows-gracefully
branch
from
d1b1edb to
865d6ee
Compare
chrisd8088
approved these changes
Jun 22, 2022
Member
chrisd8088
left a comment
chrisd8088
left a comment
There was a problem hiding this comment.
This looks great and works as expected on my test VM -- thank you! 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue raised in #5031.
/cc @chrisd8088