lfshttp: fix invalid Accept header syntax #4996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using the same value for both the HTTP request Content-Type header (which includes a charset), and the Accept header, where charset is not part of the valid syntax. Split them out into separate values.
Member
|
Hey, thanks for the patch and welcome to Git LFS! This seems correct and reasonable to me, so I'll merge it once the CI jobs turn green. Thanks again for the PR! |
chrisd8088
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git-lfs uses the same constant value for the
Content-TypeandAcceptrequest HTTP headers:But
charsetisn't valid syntax forAccept. This change splits out the constant to fix this: