workflows: use ronn-ng #4992
workflows: use ronn-ng #4992
Conversation
Recently, we changed to use the windows-2019 target because ronn fails to build on newer versions. Unfortunately, it also fails to build on that version due to updates in GitHub Actions. Since ronn itself is dead upstream, let's switch to ronn-ng, just like Debian has done. This provides an identically named binary but is a supported codebase that is more likely to work now and in the future.
|
Sweet! 🚀 I'm delighted this exists and very happy you spotted it, as it should save us a lot of effort!! |
chrisd8088
left a comment
chrisd8088
left a comment
There was a problem hiding this comment.
LGTM. I wonder if it will require ruby/setup-ruby@v1 on the Windows 2022 runners or if it will work with the older, deprecated actions/setup-ruby@v1 we're using now. The latter would mean we could probably switch to the windows-latest runners again, per #4883. If we need ruby/setup-ruby@v1, though, we may still run into problems, IIRC.
Regardless, though, this is definitely a strict improvement over the status quo.
|
I'll open an issue to track that and investigate the best way forward there. Since things aren't working now, I'd like to go with the smallest fix that will unbreak things, and then we can iteratively improve on things in the future. |
In commit f4ab4e7 of PR git-lfs#4883 we noted that the "gem install ronn" step in our Windows CI workflows currently fails on newer Windows Server 2022 GitHub Actions runners, due to possibly some missing C headers or libraries. While this could be resolved by upgrading to the "ruby/setup-ruby" action from the deprecated "actions/setup-ruby" one, that introduced a series of issues with PATH lookups as documented in ruby/setup-ruby#293. We therefore chose to continue using Windows 2019 runners until a resolution or workaround was found. Fortunately, as of commit 912b607 in PR git-lfs#4992 we are now using the ronn-ng Ruby gem instead of the unmaintained ronn gem, and the "gem install ronn-ng" workflow step succeeds on Windows 2022 while still using the "actions/setup-ruby" action to install a Ruby build environment. This allows us to upgrade to the latest Windows runners in GitHub Actions, although we can't yet upgrade to the "ruby/setup-ruby" workflow action. h/t to @bk2204 for finding ronn-ng!
2 participants
Recently, we changed to use the windows-2019 target because ronn fails to build on newer versions. Unfortunately, it also fails to build on that version due to updates in GitHub Actions.
Since ronn itself is dead upstream, let's switch to ronn-ng, just like Debian has done. This provides an identically named binary but is a supported codebase that is more likely to work now and in the future.