Build test helper commands with .exe file extension on Windows
#4954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, it is convenient to have the .exe file extension added to our compiled test helpers when running tests manually, so we use the X variable to do so in the same manner as in the primary Makefile. Also, we add a test-commands Makefile target which is convenient when re-building just the test helpers.
bk2204
approved these changes
Apr 20, 2022
Member
bk2204
left a comment
bk2204
left a comment
There was a problem hiding this comment.
I've also found myself wanting a target to rebuild just the test commands, so thanks for adding this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, it is convenient to have the
.exefile extension added to our compiled test helpers when running tests manually, so we use theXvariable to do so in the same manner as in the primaryMakefile.Also, we add a
test-commandstarget int/Makefilewhich is convenient when rebuilding just the test helpers.