-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Git for CentOS #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Git for CentOS #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleaned up the used of SUDO so that it is needed less
Contributor
|
Awesome, thanks!
Once we get Git LFS v0.6.0 shipped, I want to look at getting CI builds to run on a wider variety of OS's to catch stuff like this. |
technoweenie
added a commit
that referenced
this pull request
Jul 22, 2015
technoweenie
added a commit
that referenced
this pull request
Jul 22, 2015
Backport #480 for v0.5.x: Git for CentOS
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Dec 27, 2022
In commit cd3e92e of PR git-lfs#480 we introduced support for CentOS 6 into our rpm/build_rpms.bsh script by building an early version of Git from a local git.spec file. Then in commit d2d90a8 of PR git-lfs#891 this was replaced with installation from the setup.ius.io service. In commit git-lfs/build-dockers@7af5552 of PR git-lfs/build-dockers#19, however, the download and installation of Git 2.16 from github.com was added to the CentOS 6 Dockerfile; later this was adjusted to download from kernel.org. In commit git-lfs/build-dockers@f1f573f of PR git-lfs/build-dockers#29 we added support for CentOS 8, which supports a direct installation of Git using yum. And in commit git-lfs/build-dockers@898d9b0 of PR git-lfs/build-dockers#33 we dropped support for CentOS 6 entirely. Therefore we no longer have any need for our rpm/build_rpms.bsh script to install Git at all, especially not very old versions, so we simply remove that logic from our script.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Dec 27, 2022
In commit cd3e92e of PR git-lfs#480 we introduced support for CentOS 6 into our rpm/build_rpms.bsh script by building an early version of Git from a local git.spec file. Then in commit d2d90a8 of PR git-lfs#891 this was replaced with installation from the setup.ius.io service. In commit git-lfs/build-dockers@7af5552 of PR git-lfs/build-dockers#19, however, the download and installation of Git 2.16 from github.com was added to the CentOS 6 Dockerfile; later this was adjusted to download from kernel.org. In commit git-lfs/build-dockers@f1f573f of PR git-lfs/build-dockers#29 we added support for CentOS 8, which supports a direct installation of Git using yum. And in commit git-lfs/build-dockers@898d9b0 of PR git-lfs/build-dockers#33 we dropped support for CentOS 6 entirely. Therefore we no longer have any need for our rpm/build_rpms.bsh script to install Git at all, especially not very old versions, so we simply remove that logic from our script.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Dec 27, 2022
Since the original introduction of the rpm/build_rpms.bsh script in commit 4a71627 of PR git-lfs#332 it has installed a number of packages, including make, curl, tar, and bison. Then in commit a4c9db8 of PR git-lfs#480 the perl-Digest-SHA package was added as an install target as well. However, we no longer need to install any of these, either because the are already installed by our CentOS and Rocky Linux Dockerfiles in our git-lfs/build-dockers project, or because they are simply unused at present, so we remove these packages now.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Dec 28, 2022
In commit cd3e92e of PR git-lfs#480 we introduced support for CentOS 6 into our rpm/build_rpms.bsh script by building an early version of Git from a local git.spec file. Then in commit d2d90a8 of PR git-lfs#891 this was replaced with installation from the setup.ius.io service. In commit git-lfs/build-dockers@7af5552 of PR git-lfs/build-dockers#19, however, the download and installation of Git 2.16 from github.com was added to the CentOS 6 Dockerfile; later this was adjusted to download from kernel.org. In commit git-lfs/build-dockers@f1f573f of PR git-lfs/build-dockers#29 we added support for CentOS 8, which supports a direct installation of Git using yum. And in commit git-lfs/build-dockers@898d9b0 of PR git-lfs/build-dockers#33 we dropped support for CentOS 6 entirely. Therefore we no longer have any need for our rpm/build_rpms.bsh script to install Git at all, especially not very old versions, so we simply remove that logic from our script.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Dec 28, 2022
Since the original introduction of the rpm/build_rpms.bsh script in commit 4a71627 of PR git-lfs#332 it has installed a number of packages, including make, curl, tar, and bison. Then in commit a4c9db8 of PR git-lfs#480 the perl-Digest-SHA package was added as an install target as well. However, we no longer need to install any of these, either because the are already installed by our CentOS and Rocky Linux Dockerfiles in our git-lfs/build-dockers project, or because they are simply unused at present, so we remove these packages now.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Dec 28, 2022
Since the original introduction of the rpm/build_rpms.bsh script in commit 4a71627 of PR git-lfs#332 it has installed a number of packages, including make, curl, tar, and bison. Then in commit a4c9db8 of PR git-lfs#480 the perl-Digest-SHA package was added as an install target as well. However, we no longer need to install any of these, either because the are already installed by our CentOS and Rocky Linux Dockerfiles in our git-lfs/build-dockers project, or because they are simply unused at present, so we remove these packages now.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 13, 2023
The last substantive update to the docs/linux-build.md file was made in PR git-lfs#480 in 2015, and the information in the file is no longer accurate or relevant. While the `rpm/build_rpms.bsh` script mentioned in the text still exists, we typically run that script only within Docker containers, and we have updated our Docker build documentation both in prior commits in this PR and in PR git-lfs/build-dockers#57. Therefore we simply remove the old docs/linux-build.md file in favour of our revised documentation, which describes how to build and use Docker images to generate both Debian and RPM packages of Git LFS.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 13, 2023
The last substantive update to the docs/linux-build.md file was made in PR git-lfs#480 in 2015, and the information in the file is no longer accurate or relevant. While the `rpm/build_rpms.bsh` script mentioned in the text still exists, we typically run that script only within Docker containers, and we have updated our Docker build documentation both in prior commits in this PR and in PR git-lfs/build-dockers#57. Therefore we simply remove the old docs/linux-build.md file in favour of our revised documentation, which describes how to build and use Docker images to generate both Debian and RPM packages of Git LFS.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 13, 2023
The last substantive update to the docs/linux-build.md file was made in PR git-lfs#480 in 2015, and the information in the file is no longer accurate or relevant. While the `rpm/build_rpms.bsh` script mentioned in the text still exists, we typically run that script only within Docker containers, and we have updated our Docker build documentation both in prior commits in this PR and in PR git-lfs/build-dockers#57. Therefore we simply remove the old docs/linux-build.md file in favour of our revised documentation, which describes how to build and use Docker images to generate both Debian and RPM packages of Git LFS.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 13, 2023
The last substantive update to the docs/linux-build.md file was made in PR git-lfs#480 in 2015, and the information in the file is no longer accurate or relevant. While the `rpm/build_rpms.bsh` script mentioned in the text still exists, we typically run that script only within Docker containers, and we have updated our Docker build documentation both in prior commits in this PR and in PR git-lfs/build-dockers#57. Therefore we simply remove the old docs/linux-build.md file in favour of our revised documentation, which describes how to build and use Docker images to generate both Debian and RPM packages of Git LFS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-CentOS 6 only has git 1.7 available. So I had to take the existing git rpm, and update it to 2.4.5. Ever feature and capability should have been ported (Emacs, perl, etc...) So that it could probably replace the existing git with no ill effect...
-CentOS 5 was pulling an 1.7 version instead of an available 1.8.2 version. The scripts has been updated to pull the compatible version
-Building no longer fails when sudo in not installed requiring the developer to set the SUDO environment variable
-Building the SRPM no longer fails due to bad permissions
Docs updated
-Many (but far less now) integration tests still fail. I'm using this for active software development in CentOS 6.6, and it does work.