Add support for Windows ARM64#4586
Conversation
Go 1.17 added support for building for Windows arm64. This commit adds that support to Git LFS, including the required CI + installer logic.
| //go:build windows && arm64 | ||
| // +build windows,arm64 | ||
|
|
||
| //go:generate goversioninfo -arm=true |
There was a problem hiding this comment.
The -arm flag needs to be defined explicitly when building for Windows ARM64. Support for this was added a few days ago: josephspurrier/goversioninfo#51. If you know a more efficient way of doing this rather than creating a new .go file, by all means 😊
There was a problem hiding this comment.
I don't have a better suggestion. We practically never modify those files, so the burden of adding one more should be negligible.
bk2204
left a comment
bk2204
left a comment
There was a problem hiding this comment.
Hey,
Thanks for the patch. I'm especially delighted you put fixes into the installer script, which is an area I'm not very familiar with. I had a few questions here, but overall I feel good about this change and I think once those are answered we should be good to go.
| //go:build windows && arm64 | ||
| // +build windows,arm64 | ||
|
|
||
| //go:generate goversioninfo -arm=true |
There was a problem hiding this comment.
I don't have a better suggestion. We practically never modify those files, so the burden of adding one more should be negligible.
bk2204
left a comment
bk2204
left a comment
There was a problem hiding this comment.
This looks good. Thanks again for the patch.
Git LFS has supported Windows arm64 since 2021. Let's add it to the dependencies, now that Git itself also support it. Ref: git-lfs/git-lfs#4586 Signed-off-by: Dennis Ameling <[email protected]>
Git LFS has supported Windows arm64 since 2021. Let's add it to the dependencies, now that Git itself also support it. Ref: git-lfs/git-lfs#4586 Signed-off-by: Dennis Ameling <[email protected]>
2 participants
Follow-up PR on #4584
Go 1.17 added support for the Windows ARM64 build target. This PR adds that support to Git LFS, including the required CI + installer logic.
The installer correctly recognizes ARM64 and writes to the
Program Filesfolder (notProgram Files (x86)):The installed executable is native ARM64 indeed: