Bump Go to 1.17#4584
Merged
Merged
Conversation
From the 1.17 release notes (https://golang.org/doc/go1.17#gofmt): gofmt (and go fmt) now synchronizes //go:build lines with // +build lines. More info about this change can be found at https://golang.org/design/draft-gobuild
bk2204
approved these changes
Aug 17, 2021
bk2204
left a comment
bk2204
left a comment
Member
There was a problem hiding this comment.
Hey, thanks for the patch, and welcome to Git LFS! This looks fine to me, and assuming it passes CI, I'll go ahead and merge it.
Contributor
Author
|
Looks like we have a flaky test: https://github.com/git-lfs/git-lfs/pull/4584/checks?check_run_id=3353935029. It passed on my fork (https://github.com/dennisameling/git-lfs/runs/3353759407?check_suite_focus=true) so it should work - would you mind restarting the CI workflow? 🤞🏼 |
Member
|
I've kicked a fresh run off. Normally that test is not flaky, but hopefully it will pass this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.17 has been released. One of the new features is that it now supports Windows ARM64 🎉 I'd like to create a PR for that, but before I do, here's a separate PR for bumping Go to 1.17 first.
There's new
//go:buildlines - Go now understands//go:buildlines and prefers them over// +buildlines:This PR adds the lines that
make fmthas created. For backward compatibility reasons, the new//go:buildlines were added and kept in sync with// +buildas mentioned above.