Skip to content

Comments

Autodetect protocol from git address#25

Merged
CatTail merged 1 commit intogit-hooks:masterfrom
rvasilevsf:master
Apr 4, 2019
Merged

Autodetect protocol from git address#25
CatTail merged 1 commit intogit-hooks:masterfrom
rvasilevsf:master

Conversation

@rumenvasilev
Copy link

@rumenvasilev rumenvasilev commented Apr 3, 2019

This PR adds support for detecting the protocol from the githooks.json. Previously it was assuming all connections are going over https. Now they can go over ssh as well.
Example structure:

{
    "pre-commit": {
        "ssh://[email protected]:org/repo": [
            "script1"
        ],
        "https://my.git.repo/org/repo": [
            "script1"
        ],
        "my.git.repo/org/repo": [
            "script1"
        ]
    }
}

CatTail
CatTail approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@CatTail CatTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for add this feature

@CatTail CatTail merged commit bbb19f8 into git-hooks:master Apr 4, 2019
@CatTail
Copy link
Member

CatTail commented Apr 4, 2019

v1.2.0 is the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CatTail CatTail CatTail approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rumenvasilev @CatTail @rvasilevsf