Workaround certain anti-malware programs by chirpnot · Pull Request #37 · git-for-windows/msys2-runtime

chirpnot · 2022-01-04T15:09:54Z

This might break things, but it turns out several Windows libraries like to be loaded at 0x180000000.

This causes a problem, because msys-2.0.dll loads at 0x180040000 and expects 0x180000000-0x180040000 to be available.
A problem arises when Antiviruses (or other DLL hooking mechanisms) load a dll whose preferred load address is 0x180000000 and fits in size before 0x180010000:

msys-2.0.dll loads and fills 0x180010000-0x180040000 assuming no shared console structure is going to be needed.
Another dll loads and fills 0x180000000-0x18000xxxx
msys-2.0.dll tries to load 0x180000000-0x180010000 but it's not available. It falls back to another address, but down the line something else fails.

This bug triggers when using subshells (e.g.: git clone --recursive).

(I guess msys should be able to work around the address conflict, but the code is failing in some way and I'm having a hard time figuring it out, so...)

This addresses git-for-windows/git#3539

dscho · 2022-01-05T15:05:55Z

A couple of comments:

Could I ask you to use your real name and email address in your user.name and user.email configuration and then call git commit --amend --reset-author -s, then force-push?
How did you come up with 0x210347000?
I cherry-picked two fixes to allow the CI build to start.
Since the build now succeeds, and since I have no way to reproduce the original issue, could I ask you to test the build artifact?

chirpnot · 2022-03-10T15:37:03Z

Could I ask you to use your real name and email address in your user.name and user.email configuration and then call git commit --amend --reset-author -s, then force-push?

Will do.

How did you come up with 0x210347000?

You mean 0x210040000? Random choice. If you have any scientific-like idea to get a new base address, my ears are wide open.

The only semi-feasible approach imho would be to take a windows install and query all the base addresses of all the exe/dll's and then choose something that's not there, but still...

I cherry-picked two fixes to allow the CI build to start.

Since the build now succeeds, and since I have no way to reproduce the original issue, could I ask you to test the build artifact?

I confirm it seems to work. I managed to get .\strace.exe .\cmd.exe => .\lsattr.exe to crash in git-for-windows but not in your CI build.

.\strace.exe .\ldd.exe crashes both, but I think it's unrelated. Could you please try it on your machine?

chirpnot · 2022-03-10T15:50:48Z

Ok, even rebasing msys-2.0.dll in the broken version, strace lsattr still crashes :/ so I guess it's unrelated. Will do some more differential testing.

EDIT: since the CI build doesn't come with many complex programs, I simply dropped msys-2.0.dll from the CI into git-for-windows and cloned a repo with --recursive. No crash. This increases my gut feeling that the strace thing is another problem.

This might break things, but it turns out several Windows libraries like to be loaded at 0x180000000. This causes a problem, because `msys-2.0.dll` loads at `0x180040000` and expects `0x180000000-0x180040000` to be available. A problem arises when Antiviruses (or other DLL hooking mechanisms) load a DLL whose preferred load address is `0x180000000` and fits in size before `0x180010000`: 1. `msys-2.0.dll` loads and fills `0x180010000-0x180040000` assuming no shared console structure is going to be needed. 2. Another DLL loads and fills `0x180000000-0x18000xxxx` 3. `msys-2.0.dll` tries to load `0x180000000-0x180010000` but it's not available. It falls back to another address, but down the line something else fails. This bug triggers when using subshells (e.g.: `git clone --recursive`). The MSYS2 runtime should be able to work around the address conflict, but the code is failing in some way or other... Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Mikael Larsson <[email protected]>

dscho · 2022-05-10T19:57:11Z

@orgads since you have access to Windows 7, could I trouble you to test this?

orgads · 2022-05-10T19:59:35Z

Sure, I'll test it tomorrow.

orgads · 2022-05-11T07:52:19Z

Works for me on Win7. No crash on git clone --recursive (I didn't try to reproduce with the official version).

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho · 2022-05-13T21:33:18Z

Thank you @chirpnot!

Many anti-malware products seem to have problems with our MSYS2 runtime, leading to problems running e.g. `git subtree`. We [added a workaround](git-for-windows/msys2-runtime#37) that hopefully helps in most of these scenarios. Signed-off-by: Johannes Schindelin <[email protected]>

Stmgme

K

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho force-pushed the main branch 3 times, most recently from 8d105b8 to d3507f2 Compare January 5, 2022 14:40

chirpnot force-pushed the main branch from 34ecb7c to 9ba7fb1 Compare March 10, 2022 16:43

dscho force-pushed the main branch from 9ba7fb1 to c167655 Compare May 10, 2022 19:56

dscho changed the title ~~Workaround for #3539~~ Workaround certain anti-malware programs May 13, 2022

dscho merged commit d92c46b into git-for-windows:main May 13, 2022

dscho added a commit to dscho/msys2-runtime that referenced this pull request May 13, 2022

Merge pull request git-for-windows#37 from chirpnot/main

a3d2ace

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

Stmgme reviewed Jul 2, 2022

View reviewed changes

N6REJ mentioned this pull request Jul 11, 2022

msys-2-0.dll quarantined by Malwarebytes git-for-windows/git#3943

Closed

dscho added a commit to dscho/msys2-runtime that referenced this pull request Sep 5, 2022

Merge pull request git-for-windows#37 from chirpnot/main

0d88b13

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

rimrul mentioned this pull request Mar 8, 2023

Submodule update fails after GIT version 2.25.1 with Git Extensions git-for-windows/git#3356

Closed

1 task

dscho added a commit to dscho/msys2-runtime that referenced this pull request May 12, 2023

Merge pull request git-for-windows#37 from chirpnot/main

a58c61b

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Jun 16, 2023

Merge pull request git-for-windows#37 from chirpnot/main

36e3862

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Jun 19, 2023

Merge pull request git-for-windows#37 from chirpnot/main

de67bb6

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Sep 6, 2023

Merge pull request git-for-windows#37 from chirpnot/main

e5d5d94

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Nov 29, 2023

Merge pull request git-for-windows#37 from chirpnot/main

e33a8c9

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Aug 30, 2024

Merge pull request git-for-windows#37 from chirpnot/main

0dc855f

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Sep 5, 2024

Merge pull request git-for-windows#37 from chirpnot/main

f631c19

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Sep 18, 2024

Merge pull request git-for-windows#37 from chirpnot/main

1ff1749

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Dec 24, 2024

Merge pull request git-for-windows#37 from chirpnot/main

070aa27

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Jan 26, 2025

Merge pull request git-for-windows#37 from chirpnot/main

7b8263b

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Jan 26, 2025

Merge pull request git-for-windows#37 from chirpnot/main

f8a56d8

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Jan 26, 2025

Merge pull request git-for-windows#37 from chirpnot/main

7691cfa

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Jan 27, 2025

Merge pull request git-for-windows#37 from chirpnot/main

e7d5ec7

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Jan 28, 2025

Merge pull request git-for-windows#37 from chirpnot/main

b589714

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Jan 30, 2025

Merge pull request git-for-windows#37 from chirpnot/main

249374c

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Mar 21, 2025

Merge pull request git-for-windows#37 from chirpnot/main

d300cea

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Mar 21, 2025

Merge pull request git-for-windows#37 from chirpnot/main

00760c0

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Apr 9, 2025

Merge pull request git-for-windows#37 from chirpnot/main

08e3b1e

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Apr 9, 2025

Merge pull request git-for-windows#37 from chirpnot/main

7534641

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request May 26, 2025

Merge pull request git-for-windows#37 from chirpnot/main

3a2a423

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Jun 5, 2025

Merge pull request git-for-windows#37 from chirpnot/main

377b4b8

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Jul 15, 2025

Merge pull request git-for-windows#37 from chirpnot/main

cf95845

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit that referenced this pull request Oct 10, 2025

Merge pull request #37 from chirpnot/main

c7c08d2

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Jan 15, 2026

Merge pull request git-for-windows#37 from chirpnot/main

5b07297

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit to dscho/msys2-runtime that referenced this pull request Mar 2, 2026

Merge pull request git-for-windows#37 from chirpnot/main

bc9c136

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit that referenced this pull request Apr 25, 2026

Merge pull request #37 from chirpnot/main

4d57318

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

dscho added a commit that referenced this pull request Jul 14, 2026

Merge pull request #37 from chirpnot/main

19346ce

Workaround certain anti-malware programs Signed-off-by: Johannes Schindelin <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Workaround certain anti-malware programs#37

Workaround certain anti-malware programs#37
dscho merged 1 commit into
git-for-windows:mainfrom
chirpnot:main

chirpnot commented Jan 4, 2022 •

edited by dscho

Loading

Uh oh!

dscho commented Jan 5, 2022

Uh oh!

chirpnot commented Mar 10, 2022

Uh oh!

chirpnot commented Mar 10, 2022 •

edited

Loading

Uh oh!

dscho commented May 10, 2022

Uh oh!

orgads commented May 10, 2022

Uh oh!

orgads commented May 11, 2022 •

edited

Loading

Uh oh!

dscho commented May 13, 2022

Uh oh!

Stmgme left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

chirpnot commented Jan 4, 2022 • edited by dscho Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dscho commented Jan 5, 2022

Uh oh!

chirpnot commented Mar 10, 2022

Uh oh!

chirpnot commented Mar 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dscho commented May 10, 2022

Uh oh!

orgads commented May 10, 2022

Uh oh!

orgads commented May 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dscho commented May 13, 2022

Uh oh!

Stmgme left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chirpnot commented Jan 4, 2022 •

edited by dscho

Loading

chirpnot commented Mar 10, 2022 •

edited

Loading

orgads commented May 11, 2022 •

edited

Loading