Deal with expired installation access tokens#32
Merged
Conversation
We recently ran into an expiring installation access token. To remedy that, we will want to return not only the token but also its expiry date. Prepare for that. Signed-off-by: Johannes Schindelin <[email protected]>
The build https://github.com/git-for-windows/git-for-windows-automation/actions/runs/4153007326/jobs/7184357891 as well the build https://github.com/git-for-windows/git-for-windows-automation/actions/runs/4153007483/jobs/7184358147 failed due to an expiring installation access token: these tokens expire after an hour, and the step that built the Pacman package took well over an hour. To cope with that, remember the expiry date of the token, and after the Pacman package has been built, refresh it if it is expired (or running the danger of expiring while the packages are deployed). Signed-off-by: Johannes Schindelin <[email protected]>
rimrul
approved these changes
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Apps' installation access tokens expire after an hour.
That is the reason why the
mingw-w64-gnutlsand themingw-w64-gnutls(aarch64)builds failed: it took more than an hour to build those Pacman packages.Work around such issues by refreshing the installation access token if needed.
Here is a workflow run demonstrating (via essentially a dry-run) that the non-expiring case still works as expected, and here is a workflow run where an expired token was simulated, and it still managed to update the check run.