Drop the i686 variant of Bash#192
Merged
Merged
Conversation
The Bash v5.3.9 update causes i686-specific build failures due to a libreadline version clash; see git-for-windows/MSYS2-packages#269 Since 32-bit MinGit is the only remaining i686 artifact offered by Git for Windows, and there is nothing critical in this Bash update for it, fixing those build issues is not worth the trouble. Signed-off-by: Johannes Schindelin <[email protected]>
rimrul
requested changes
Feb 9, 2026
| msysName, | ||
| version, | ||
| package_name === 'pcre2' | ||
| ['pcre2', 'bash'].includes(package_name) |
Member
There was a problem hiding this comment.
We're In the packageNeedsBothMSYSAndMINGW() arm here. That doesn't seem right for bash.
Member
Author
There was a problem hiding this comment.
Oh, of course! Thanks for the good eyes!
Member
There was a problem hiding this comment.
The check for bash should probably go here.
…loyed As of the Bash v5.3.9 update (see git-for-windows/MSYS2-packages#269), it is intentional that the i686 variant of that package is no longer deployed. Signed-off-by: Johannes Schindelin <[email protected]>
rimrul
approved these changes
Feb 9, 2026
mjcheetham
approved these changes
Feb 9, 2026
dscho
added a commit
that referenced
this pull request
Jun 23, 2026
Currently, `/deploy` spawns _two_ workflow runs for regular MINGW packages: one that builds the `clangarm64` variant of the package, and one that combines the `mingw32` and `mingw64` builds. (Exceptions: `git-credential-manager`, `git-lfs` and `wintoast`, where the executables are not actually built using the MINGW toolchains provided by the MSYS2 project.) With the currently ongoing [migration](git-for-windows/git-sdk-64#117) from MINGW64 to UCRT64, it is as good a time as any to split that combined build, and simply trigger separate workflow runs for all the separate MINGW flavors (`MINGW_ARCH` in MSYS2 parlance). This _also_ prepares for dramatically restricting the set of packages to be updated in the 32-bit builds of Git for Windows: Even though Git for Windows promises to provide MinGit 32-bit builds [until 2029](https://gitforwindows.org/32-bit#until-2029-mingit-only-32-bit-support), the uphill battle to maintain 32-bit support requires making concessions by focusing on an even smaller set of components that _must_ be updated for that architecture. I am thinking about cURL, OpenSSL and OpenSSH, and stopping to update, say, PCRE2 and xpdf-tools for 32-bit. Bash, for example, is [no longer updated](#192) for 32-bit at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of git-for-windows/MSYS2-packages#269, the effort of fixing i686-only build failures is too much, and we're no longer updating Git for Windows' i686 Bash (which would be used for MinGit only, anyway).