Skip to content

installer: allow silent install of 32-bit installer on ARM64#492

Merged
dscho merged 1 commit into
git-for-windows:mainfrom
rimrul:fix-arm64-silent-install
Apr 19, 2023
Merged

installer: allow silent install of 32-bit installer on ARM64#492
dscho merged 1 commit into
git-for-windows:mainfrom
rimrul:fix-arm64-silent-install

Conversation

@rimrul

@rimrul rimrul commented Apr 15, 2023

Copy link
Copy Markdown
Member

When Installing 32-bit Git for Windows we show a Warning that we're deprecating 32-bit support, but there are two Versions of the 32-bit warning. The Version shown on 32-Bit Windows allows a silent install, while the Version on 64-Bit Windows does not. This is fine on AMD64, but for Windows 10 on ARM64 we don't have a good alternative offer. So show them the same message as we show on i686.

When Installing 32-bit Git for Windows we show a Warning that we're deprecating
32-bit support, but there are two Versions of the 32-bit warning. The Version
shown on 32-Bit Windows allows a silent install, while the Version on 64-Bit
Windows does not. This is fine on AMD64, but for Windows 10 on ARM64
we don't have a good alternative offer. So show them the same message as we show
on i686.

Signed-off-by: Matthias Aßhauer <[email protected]>
@dscho

dscho commented Apr 16, 2023

Copy link
Copy Markdown
Member

for Windows 10 on ARM64 we don't have a good alternative offer.

Do we really have to care about Windows 10 for ARM64? It was my understanding that it was still marked as experimental, and that you'd really would need to go for Windows 11 if you want to use a full-featured Windows/ARM64.

If we want to allow a silent install of 32-bit Git for Windows on ARM64, then I would insist on doing that only on Windows 10. On Windows 11 users should install the 64-bit variant.

@rimrul

rimrul commented Apr 16, 2023

Copy link
Copy Markdown
Member Author

Do we really have to care about Windows 10 for ARM64?

I'd treat it as regular x86 Windows 10, as far as the installer is concerned.

If we want to allow a silent install of 32-bit Git for Windows on ARM64, then I would insist on doing that only on Windows 10. On Windows 11 users should install the 64-bit variant.

I've thought about that, but I think I'd prefer to recommend the upcomming native ARM64 version there, once we have official ARM64 releases and avoid recommending a stepping stone in between. Though I guess the intermediary step via AMD64 is not the worst thing.

@dscho

dscho commented Apr 18, 2023

Copy link
Copy Markdown
Member

the upcomming native ARM64 version

There is still the blocker that we have unexplained (and unfixed) hangs in the MSYS2 runtime when code-signing the executables. Before that is resolved, we cannot move forward with Git for Windows/ARM64. And while I'd love to work on this (it seems like a good debugging challenge) I fear I currently lack the time and energy to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants