installer: warn about 32-bit deprecation#482
Conversation
mjcheetham
left a comment
mjcheetham
left a comment
There was a problem hiding this comment.
👍 Looks great! Don't suppose adding a link to info about the end of support is possible, given this is a simple MsgBox?
@mjcheetham unfortunately, it seems that this is not possible. The suggested workaround would be to let one of the buttons of the message box open a link, but out of the available buttons ("OK", "Cancel", "Abort", "Retry", "Ignore", "Yes", and "No"), nothing strikes me as an obvious good choice. But I guess I could reword the message box thusly:
Another question is whether I should mention v2.40.x explicitly, or whether it is better to stay vague because we will continue to build 32-bit Git for Windows even with v2.41.x, it's just that the MSYS2 runtime won't be the latest and greatest anymore... What do you think? |
Yeah none of those make any sense.
That may work too (except the term "ticket" sounds weird..), but what about the 32-on-64 message? How about:
..and..
Staying vague is probably better. |
Since Git for Windows relies on the MSYS2 runtime for POSIX emulation as required e.g. by the Bash (which is used by Git to execute aliases, hooks, and the `git submodule` command), and since the MSYS2 project already dropped support for the i686 variant of the MSYS2 runtime (following Cygwin's lead), Git for Windows won't be able to provide full support of 32-bit installers going forward. Let's warn the users about this. Signed-off-by: Johannes Schindelin <[email protected]>
7b778be to
5f9a91e
Compare
|
@mjcheetham I force-pushed an update (and with this update, this here PR needs git-for-windows/git-for-windows.github.io#43 to be merged first). The dialog boxes now look like this:
|
Looks great! I think adding the URL is helpful as overtime you can update the webpage with more concrete dates and version numbers etc. |
The warning is intended to let users know that Git for Windows (i686 variant) is soon no longer going to be serviced. Signed-off-by: Johannes Schindelin <[email protected]>
5f9a91e to
c800a3f
Compare
|
Technically, it would be possible to implement a custom message box with an "Open link" button. However, the styling would be different, and to support the "Suppressible" part of I've decided that there are more pressing things that I need to attend to ;-) |
By "link" I mean adding the URL, which you have done. No need to add a hyperlink!
100% |
Still, a hyperlink would be nicer for users. |
|
Hello, please let me know if you would prefer an issue opened for this. It seems this change breaks installing the 32-bit version silently with /SUPPRESSMSGBOXES, as it defaults to "No" and cancels the installation when running silently. Was this the intended outcome of this change? |
Note that this behaviour only affects 64bit Windows, as the message box has no "No" option on 32bit Windows. See also #492 and git-for-windows/git#4347. According to git-for-windows/git#4347 (comment) this is intentional. |
|
Ahh, that is what I needed to know. Thanks for pointing that out and apologies for not finding it on my own! |
4 participants
As per git-for-windows/git#4279, Git for Windows is deprecating the 32-bit variant. Let's teach the installer to detect when a user is installing this variant and show an appropriate warning in that case. On a 32-bit Windows, they will see this type of dialog box:
On a 64-bit Windows, they will see this dialog box: