Skip to content

installer: add arm64 artifact option#326

Merged
dscho merged 1 commit into
git-for-windows:mainfrom
dennisameling:installer-arm64
Feb 6, 2021
Merged

installer: add arm64 artifact option#326
dscho merged 1 commit into
git-for-windows:mainfrom
dennisameling:installer-arm64

Conversation

@dennisameling

Copy link
Copy Markdown
Member

Adds ARM64 support to the installer 🚀

Currently installs ARM64 Git into C:\Program Files (x86)\Git by default.

Comment thread installer/release.sh Outdated

@dscho dscho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress!

Comment thread installer/release.sh Outdated
Comment thread installer/release.sh Outdated
Comment thread installer/install.iss
@dscho

dscho commented Feb 4, 2021

Copy link
Copy Markdown
Member

There is one more concern that I forgot to mention earlier: if we try to include artifacts from a directory outside of the pseudo root, the given approach won't work.

It would probably make more sense to imitate the $include_pdbs approach (but you don't need to copy, you just need to set the Source: attribute to the actual (Windows) path).

I admit that the sed call in the $include_pdbs clause is not for the faint of heart ;-)

@dennisameling
dennisameling force-pushed the installer-arm64 branch 2 times, most recently from 9ef9d70 to 0e969f0 Compare February 4, 2021 20:04
@dennisameling

dennisameling commented Feb 4, 2021

Copy link
Copy Markdown
Member Author

Alright, just applied your suggestions! I did go with copying the files though; don't know how to convert the Unix-based /arm64 path to the Windows path in this case 😊

After installation, everything looks good:

image

@dennisameling
dennisameling requested a review from dscho February 4, 2021 20:08

@dscho dscho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there! ;-)

Comment thread installer/release.sh
Comment thread installer/release.sh Outdated
@dennisameling

Copy link
Copy Markdown
Member Author

Thanks! Just applied your suggestions @dscho. Tested and just had to apply a very minimal change to the sed command. Works now without copying the files first. Didn't know you can use cygpath to convert a Unix to a Windows path; learning something new every day 😊

@dscho dscho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dscho
dscho merged commit d2911a0 into git-for-windows:main Feb 6, 2021
@dennisameling
dennisameling deleted the installer-arm64 branch February 6, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants