git(wrapper): fix a segmentation fault on Windows/ARM64#47
Merged
dscho merged 1 commit intoMar 7, 2021
Merged
Conversation
When calling `cmd\git.exe`, we now really want `msystem_bin` _not_ to be `NULL`. This partially fixes git-for-windows/git#3083. Signed-off-by: Johannes Schindelin <[email protected]>
1 task
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dennisameling
approved these changes
Mar 7, 2021
dennisameling
left a comment
dennisameling
left a comment
Member
There was a problem hiding this comment.
Can confirm this fixes the segfault indeed, thanks a lot @dscho! 🚀
Before applying this PR:
C:\Users\denni>where git
C:\Program Files (x86)\Git\cmd\git.exe
C:\Users\denni>git version
(CRASH)
After applying this PR:
C:\Users\denni>where git
C:\Program Files (x86)\Git\cmd\git.exe
C:\Users\denni>git version
git version 2.31.0.GIT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
cmd\git.exe, we now really wantmsystem_binnot to beNULL.This partially fixes git-for-windows/git#3083.
/cc @dennisameling