Skip to content

Make GPG Pass store path configurable by git config#1698

Merged
mjcheetham merged 2 commits into
git-ecosystem:mainfrom
ipitsyn:gpgpath
Sep 30, 2024
Merged

Make GPG Pass store path configurable by git config#1698
mjcheetham merged 2 commits into
git-ecosystem:mainfrom
ipitsyn:gpgpath

Conversation

@ipitsyn

@ipitsyn ipitsyn commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

I found this change beneficial when using conditional git configuration includes for multiple git identities and pass password stores. It lets me transparently select appropriate password store without need to set its path explicitly by environment variable.
For example:

~/.config/git/config:

[user]
	name = John Doe
	email = [email protected]

[credential]
	credentialStore = gpg
	helper = /usr/local/bin/git-credential-manager
	gpgPassStorePath = /home/jdoe/.password-store

[includeIf "gitdir:~/Work/"]
	path = config.work

~/.config/git/config.work:

[user]
	name = John Doe (Umbrella Corp.)
	email = [email protected]

[credential]
	gpgPassStorePath = /home/jdoe/.password-store.umbrella

mjcheetham
mjcheetham requested changes Sep 5, 2024
View reviewed changes

@mjcheetham mjcheetham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks! Please can you undo the change to the VERSION file, and also can I ask that you add a new section to the docs/config.md file for the new config setting entry?

Comment thread VERSION
@@ -1 +1 @@
2.5.1.0

@mjcheetham mjcheetham Sep 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change to the VERSION file.. this is only updated by maintainers just before a release.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@Comanche85

This comment was marked as spam.

Sign in to view
@ipitsyn

ipitsyn commented Sep 9, 2024

Copy link
Copy Markdown
Contributor Author

Thanks @mjcheetham, requested has been done.

@mjcheetham

mjcheetham commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

Merging as broken links are not related to this PR.

Thanks for this contribution!

@mjcheetham
mjcheetham merged commit 4e8e593 into git-ecosystem:main Sep 30, 2024
@mjcheetham mjcheetham mentioned this pull request Sep 30, 2024
Merged
mjcheetham pushed a commit that referenced this pull request Sep 30, 2024
Matthew John Cheetham
Release GCM 2.6 (#1712)
3c28096 
**Changes:**

- Drop no longer needed workflows (#1659)
- Documentation fixes (#1664, #1697)
- Configurable GPG store path via Git config (#1698)
- Fix Visual Studio build problems and update dependencies (#1711)
- Support sending X5C with certificate auth (#1666)
@github-actions github-actions Bot mentioned this pull request Sep 30, 2024
Closed
@mdalaminak9089674532

This comment has been minimized.

Sign in to view
@coderabbitai coderabbitai Bot mentioned this pull request Jul 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcheetham mjcheetham mjcheetham approved these changes
+2 more reviewers
@Comanche85 Comanche85 Comanche85 left review comments
@tduckworth2 tduckworth2 tduckworth2 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ipitsyn @Comanche85 @mjcheetham @mdalaminak9089674532 @tduckworth2