Add support for using the current Windows user for WAM on DevBox#1197
Merged
Conversation
mjcheetham
added
auth:entra
mjcheetham
force-pushed
the
devbox
branch
4 times, most recently
from
April 18, 2023 16:55
57ed706 to
8e92194
Compare
mjcheetham
force-pushed
the
devbox
branch
4 times, most recently
from
April 25, 2023 16:47
5489a49 to
385b132
Compare
mjcheetham
marked this pull request as ready for review
April 25, 2023 18:02
Add the ability to configure MSAL to use the default OS account when the broker is enabled. Default to disabled.
mjcheetham
force-pushed
the
devbox
branch
2 times, most recently
from
April 25, 2023 21:49
8a4136a to
6f97034
Compare
Detect when we are in a Microsoft Dev Box environment, and if we are, then default to enabling the default OS account setting and enabling WAM.
ldennington
approved these changes
Apr 29, 2023
Contributor
There was a problem hiding this comment.
This is awesome, Matthew! Aside from the initial wait time, the Dev Box stuff is pretty cool, and it's very slick that the broker/default account functionality are used automatically there. I tested various GUI and terminal scenarios, and all seems to be in order.
mjcheetham
added a commit
that referenced
this pull request
May 2, 2023
**Changes:** - Support ports in URL-scoped config (#825) - Support URL-scoped enterprise default settings (#1149) - Add support for client TLS certificates (#1152) - Add TRACE2 support(#1131, #1151, #1156, #1162) - Better browser detection inside of WSL (#1148) - Handle expired OAuth refresh token for generic auth (#1196) - Target *-latest runner images in CI workflow (#1178) - Various bug fixes: - Ensure we create a WindowsProcessManager on Windows (#1146) - Ensure we start child processes created with ProcessManager (#1177) - Fix app path name of Windows dropping file extension (#1181) - Ensure we init IEnvironment before SessionManager (#1167) - git: consistently read from stdout before exit wait (#1136) - trace2: guard against null pipe client in dispose (#1135) - Make Avalonia UI the default Windows and move to in-process (#1207) - Add Git configuration options for trace & debug (#1228) - Transition from Nerdbank.GitVersioning to a version file (#1231) - Add support for using the current Windows user for WAM on DevBox (#1197) - Various documentation updates: - org-rename: update references to GitCredentialManager (#1141) - issue templates: remove core suffix (#1180) - readme: add link to project roadmap (#1204) - docs: add bitbucket app password requirements (#1213) - .net tool: clarify install instructions (#1126) - docs: call out different GCM install paths in WSL docs (#1168) - docs: add trace2 to config/env documentation (#1230)
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
mjcheetham
added
platform:windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to configure MSAL to use the default OS account when the broker is enabled.
Also detect when we are in a Microsoft Dev Box environment, and if we are, then default to enabling the new setting (and enable WAM).
Show a confirmation prompt before continuing to use the current OS account, which is similar to how Microsoft Teams operates.
Left: Avalonia UI, Right: fallback WPF window
Fixes #917