Merged
Conversation
After merging git#1953, as per https://github.com/git/git-scm.com/actions/runs/13539600621/job/37837557415#step:3:135167 the `deploy` workflow failed. This issue should have been found in a PR build, but was not. Let's make sure that similar issues will be found early in the future, before merging the respective PR. Signed-off-by: Johannes Schindelin <[email protected]>
The new checks for HTTPS enforcement found a couple of problems: git#1953 (comment) Essentially, some (quite stale) translations of the ProGit book, as well as manual pages of older Git versions, use http://git-scm.com links. And those are basically outside of our control to fix properly (in particular the manual pages of older Git versions). So let's just work around this by manually replacing them. Signed-off-by: Johannes Schindelin <[email protected]>
Contributor
|
Looks good to me. I was about to open a new PR to drop this test if it causes more trouble than it solves, but thank you for still making it work! |
Member
Author
|
It worked! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Context
#1953 tried to ensure that no links to
http://git-scm.com/were part of the deployment (note the missing "s" in "http").Unfortunately, there are plenty of such links to go around, most of them in translations of the ProGit book (out of our control) and the remaining ones in the
gitweb.confmanual pages related to Git versions prior to v2.13.0 (specifically, before commit git/git@e52a53d).This caused the
deployworkflow run to fail.I've added a work-around in this here PR by manually forcing
http://-only links specifically to git-scm.com in thebook/anddocs/pages tohttps://ones.To make sure that this kind of problem is caught in PRs before merging, I've also extended the check to catch
http://git-scm.comlinks also when deploying to a fork. To verify that this works as intended, I deployed to my fork with these changes, which was successful, and then I deployed with the fix reverted (for testing), which failed as expected./cc @b9a1