Skip to content

Work around git scm.com https misconfiguration#1956

Closed
dscho wants to merge 2 commits intogit:gh-pagesfrom
dscho:work-around-git-scm.com-https-misconfiguration
Closed

Work around git scm.com https misconfiguration#1956
dscho wants to merge 2 commits intogit:gh-pagesfrom
dscho:work-around-git-scm.com-https-misconfiguration

Conversation

@dscho
Copy link
Copy Markdown
Member

@dscho dscho commented Feb 26, 2025

Changes

Context

#1953

This will make a subsequent patch easier to understand, where we work
around a misconfiguration of git-scm.com that won't let us enforce
HTTPS in the GitHub UI at
https://github.com/git/git-scm.com/settings/pages.

Signed-off-by: Johannes Schindelin <[email protected]>
We do want to enforce HTTPS. And we kind of do, but not "kind of" enough
for GitHub's UI at https://github.com/git/git-scm.com/settings/pages to
allow us to check the box called "Enforce HTTPS".

The helpful comment next to the grayed out box says:

  [ ] **Enforce HTTPS** --- Unavailable for your site because your
  domain is not properly configured to support HTTPS
  ([`git-scm.com`](http://git-scm.com/)) --- [Troubleshooting custom
  domains](https://docs.github.com/articles/troubleshooting-custom-domains/#https-errors)

  HTTPS provides a layer of encryption that prevents others from
  snooping on or tampering with traffic to your site.
  When HTTPS is enforced, your site will only be served over HTTPS.
  [Learn more about securing your GitHub Pages site with
  HTTPS](https://docs.github.com/pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https).

As discussed in git#1953, it would
appear to be outside our capabilities to fix this properly, therefore we
are unfortunately stuck with hard-coding a work-around: Manually
override the http:// URL produced by `actions/configure-pages` with the
equivalent https:// one.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho self-assigned this Feb 26, 2025
@dscho dscho closed this Feb 26, 2025
@dscho dscho deleted the work-around-git-scm.com-https-misconfiguration branch February 26, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant