Skip to content

contrib/persistent-https: update ldflags syntax for Go 1.7+ #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
parkr wants to merge 1 commit into from
Closed

contrib/persistent-https: update ldflags syntax for Go 1.7+ #270

parkr wants to merge 1 commit into from

Conversation

@parkr
Copy link
Contributor

@parkr parkr commented Jul 15, 2016

This fixes contrib/persistent-https builds for Go v1.7+ and is compatible with Go v1.5+.

Running make all in contrib/persistent-https results in a failure on Go 1.7 and above.

Specifically, the error is:

go build -o git-remote-persistent-https \
        -ldflags "-X main._BUILD_EMBED_LABEL 1468613136"
# _/Users/parkr/github/git/contrib/persistent-https
/usr/local/Cellar/go/1.7rc1/libexec/pkg/tool/darwin_amd64/link: -X flag requires argument of the form importpath.name=value
make: *** [git-remote-persistent-https] Error 2

This name=value syntax for the -X flag was introduced in Go v1.5 (released Aug 19, 2015):

In Go v1.7, support for the old syntax was removed:

This patch includes the = to fix builds with Go v1.7+.

@parkr
contrib/persistent-https: update ldflags syntax for Go 1.7+
506701e 
This fixes contrib/persistent-https builds for Go v1.7+ and is compatible with Go v1.5+.

Running `make all` in `contrib/persistent-https` results in a failure on Go 1.7 and above.

Specifically, the error is: 

    go build -o git-remote-persistent-https \
		    -ldflags "-X main._BUILD_EMBED_LABEL 1468613136"
    # _/Users/parkr/github/git/contrib/persistent-https
    /usr/local/Cellar/go/1.7rc1/libexec/pkg/tool/darwin_amd64/link: -X flag requires argument of the form importpath.name=value
make: *** [git-remote-persistent-https] Error 2

This `name=value` syntax for the -X flag was introduced in Go v1.5 (released Aug 19, 2015):

- release notes: https://golang.org/doc/go1.5#link
- commit: golang/go@12795c0

In Go v1.7, support for the old syntax was removed:

- release notes: https://tip.golang.org/doc/go1.7#compiler
- commit: golang/go@51b624e

This patch includes the `=` to fix builds with Go v1.7+.
@parkr parkr mentioned this pull request Jul 15, 2016
Closed
@parkr parkr closed this Jul 15, 2016
@parkr parkr deleted the patch-1 branch July 15, 2016 20:35
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 2, 2020
@dscho @derrickstolee
Merge updates to serialized status
99a88a2 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 3, 2020
@dscho @derrickstolee
Merge updates to serialized status
0d6f16c 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 3, 2020
@dscho @derrickstolee
Merge updates to serialized status
ae0c595 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Dec 23, 2020
@dscho
Merge updates to serialized status
673284d 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit to derrickstolee/git that referenced this pull request Dec 24, 2020
@dscho
Merge updates to serialized status
a88c497 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Dec 29, 2020
@dscho
Merge updates to serialized status
910b645 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 19, 2021
@dscho @jeffhostetler
Merge updates to serialized status
df35772 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 10, 2021
@dscho @derrickstolee
Merge updates to serialized status
78747da 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 15, 2021
@dscho @derrickstolee
Merge updates to serialized status
417d67e 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 17, 2021
@dscho @derrickstolee
Merge updates to serialized status
1b8ce67 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 2, 2021
@dscho @derrickstolee
Merge updates to serialized status
70415c8 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 10, 2021
@dscho @derrickstolee
Merge updates to serialized status
70f9ea8 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 16, 2021
@dscho @derrickstolee
Merge updates to serialized status
c6f9f43 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jan 18, 2022
@dscho @derrickstolee
Merge updates to serialized status
51c9e51 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jan 28, 2022
@dscho @ldennington
Merge updates to serialized status
0a13891 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 16, 2022
@dscho
Merge updates to serialized status
4ce1ba4 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 22, 2022
@dscho @vdye
Merge updates to serialized status
437290e 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 23, 2022
@dscho
Merge updates to serialized status
bfb2203 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 27, 2022
@dscho
Merge updates to serialized status
0f4f4e2 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jul 14, 2022
@dscho
Merge updates to serialized status
8465077 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 30, 2022
@dscho @derrickstolee
Merge updates to serialized status
cbbb1b3 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Oct 4, 2022
@dscho
Merge updates to serialized status
f155bca 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 8, 2022
@dscho
Merge updates to serialized status
8b395e3 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
@dscho
Merge updates to serialized status
9240c0f 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
@dscho @derrickstolee
Merge updates to serialized status
d8f17a1 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 11, 2023
@dscho @derrickstolee
Merge updates to serialized status
94846ca 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 23, 2023
@dscho
Merge updates to serialized status
d5908c1 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@dscho
Merge updates to serialized status
01ec887 
Includes these pull requests:

	#1
	git#6
	git#10
	git#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@dscho @vdye
Merge updates to serialized status
b750ad7 
Includes these pull requests:

	#1
	git#6
	git#10
	git#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@dscho @derrickstolee
Merge updates to serialized status
89daca9 
Includes these pull requests:

	#1
	git#6
	git#10
	git#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@jeffhostetler
Merge pull request git#270 from jeffhostetler/fix-deserialize-error-vfs
220b1cc 
deserialize-status: silently fallback if we cannot read cache file
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@dscho @vdye
Merge updates to serialized status
1caf76f 
Includes these pull requests:

	#1
	git#6
	git#10
	git#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@dscho @derrickstolee
Merge updates to serialized status
649085a 
Includes these pull requests:

	#1
	git#6
	git#10
	git#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Apr 30, 2024
@dscho
Merge updates to serialized status
0feb1ef 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 31, 2024
@dscho
Merge updates to serialized status
130ec0d 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 19, 2024
@dscho
Merge updates to serialized status
36958c7 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jul 19, 2024
@dscho
Merge updates to serialized status
0c158e3 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 23, 2024
@dscho @mjcheetham
Merge updates to serialized status
ea134a8 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 30, 2024
@dscho
Merge updates to serialized status
bdc5e99 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Oct 9, 2024
@dscho
Merge updates to serialized status
9b44aaa 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit to derrickstolee/git that referenced this pull request Dec 10, 2024
@dscho @mjcheetham
Merge updates to serialized status
aca1a51 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 5, 2025
@dscho
Merge updates to serialized status
2a231d8 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 2, 2025
@dscho
Merge updates to serialized status
b428276 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 7, 2025
@dscho
Merge updates to serialized status
ed74b80 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@parkr