refactor(benchmark): use b.Loop() to simplify the code#4432
Merged
Conversation
Signed-off-by: efcking <[email protected]>
appleboy
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4432 +/- ##
==========================================
- Coverage 99.21% 98.96% -0.25%
==========================================
Files 42 44 +2
Lines 3182 2903 -279
==========================================
- Hits 3157 2873 -284
- Misses 17 19 +2
- Partials 8 11 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
appleboy
approved these changes
Nov 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please ensure your pull request meets the following requirements:
masterbranch.docs/doc.md.replace
for i := range b.Norfor range b.Nin a benchmark withfor b.Loop(), and remove any preceding calls tob.StopTimer,b.StartTimer, andb.ResetTimer.Supported by Go Team, more info: https://go.dev/blog/testing-b-loop
Before:
After:
go test -run=^$ -bench=. ./binding goos: darwin goarch: arm64 pkg: github.com/gin-gonic/gin/binding cpu: Apple M4 BenchmarkSliceValidationError-10 607466 1958 ns/op 1912 B/op 8 allocs/op BenchmarkMapFormFull-10 1359453 881.2 ns/op BenchmarkMapFormName-10 10900568 110.4 ns/op PASS ok github.com/gin-gonic/gin/binding 4.242s