Skip to content

refactor(context): remove unused Context dependency in get method#4304

Merged
appleboy merged 1 commit into
gin-gonic:masterfrom
1911860538:context/params
Jul 22, 2025
Merged

refactor(context): remove unused Context dependency in get method#4304
appleboy merged 1 commit into
gin-gonic:masterfrom
1911860538:context/params

Conversation

@1911860538

Copy link
Copy Markdown
Contributor
  • The get method on Context did not use its receiver c, making it misleading.
  • Renamed get to getMapFromFormData and made it a standalone function.

@codecov

codecov Bot commented Jul 19, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (3dc1cd6) to head (2a267f8).
Report is 148 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4304      +/-   ##
==========================================
- Coverage   99.21%   98.92%   -0.30%     
==========================================
  Files          42       44       +2     
  Lines        3182     3437     +255     
==========================================
+ Hits         3157     3400     +243     
- Misses         17       26       +9     
- Partials        8       11       +3     
Flag Coverage Δ
?
--ldflags="-checklinkname=0" -tags sonic 98.85% <100.00%> (?)
-tags go_json 98.85% <100.00%> (?)
-tags nomsgpack 98.90% <100.00%> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 ?
go-1.23 98.92% <100.00%> (?)
go-1.24 98.92% <100.00%> (?)
macos-latest 98.92% <100.00%> (-0.30%) ⬇️
ubuntu-latest 98.92% <100.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@appleboy appleboy added this to the v1.11 milestone Jul 22, 2025
@appleboy appleboy merged commit e4c2a27 into gin-gonic:master Jul 22, 2025
24 of 25 checks passed
@1911860538 1911860538 deleted the context/params branch July 22, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants