feat(form): add array collection format in form binding#3986
Merged
Conversation
Contributor
|
Just saw the old PR you linked and was excited to see that someone else took up the old dead PR to make this a feature in gin. Looking forward to getting this merged! |
Contributor
Author
|
Thank you for your comments. @takanuva15 |
appleboy
requested changes
Aug 14, 2024
Member
|
@slowhigh Any updates? |
Contributor
Author
|
@appleboy Thank you. Good idea. |
Contributor
Author
|
@appleboy I have addressed the lint error you mentioned. |
Member
|
@slowhigh LGTM |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3986 +/- ##
==========================================
- Coverage 99.21% 98.85% -0.36%
==========================================
Files 42 44 +2
Lines 3182 2799 -383
==========================================
- Hits 3157 2767 -390
- Misses 17 19 +2
- Partials 8 13 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
appleboy
approved these changes
Aug 24, 2024
1911860538
pushed a commit
to 1911860538/gin
that referenced
this pull request
Feb 26, 2025
* feat(form): add array collection format in form binding * feat(form): add array collection format in form binding * test(form): fix test code for array collection format in form binding
This was referenced Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the possibility of collecting array data from queries or form data by specifying the collection_format tag in structs.
Several people are waiting for this feature to be updated.
cc @Simon-Saaw
Related PR: #2750
Close #2750