feat(engine): Added OptionFunc and With#3572
Merged
Merged
Conversation
Contributor
Author
|
@appleboy Does lint information, unrelated to PR, need to be processed? |
Closed
Contributor
Author
|
lint see #3584 |
Member
|
already fixed in #3583, Please rebase the PR. |
Contributor
Author
It's already done |
Contributor
Author
|
😢 |
Contributor
Author
Contributor
Author
|
Okay, I'm tweaking related errors, this is devastating. 😂 |
Signed-off-by: Flc゛ <[email protected]>
Contributor
Author
|
@appleboy Please try again. 3Q |
Codecov Report
@@ Coverage Diff @@
## master #3572 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 42 42
Lines 3151 3156 +5
=======================================
+ Hits 3108 3113 +5
Misses 29 29
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
appleboy
approved these changes
Mar 11, 2024
OptionFunc and WithOptionFunc and With
Member
|
@flc1125 Thanks. |
moolex
reviewed
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to add an
OptionFuncto facilitate Gin configuration.Before:
But now: