Skip to content

Support the arm64e architecture for macOS/iOS#574

Merged
philipc merged 1 commit into
gimli-rs:masterfrom
arttet:master
Sep 3, 2023
Merged

Support the arm64e architecture for macOS/iOS#574
philipc merged 1 commit into
gimli-rs:masterfrom
arttet:master

Conversation

@arttet

@arttet arttet commented Aug 30, 2023 •
edited by philipc
Loading

Copy link
Copy Markdown
Contributor

Closes #573

bjorn3
bjorn3 reviewed Aug 30, 2023
View reviewed changes
Comment thread src/write/elf/object.rs Outdated
@arttet arttet marked this pull request as draft August 30, 2023 16:08
philipc
philipc reviewed Aug 31, 2023
View reviewed changes
Comment thread crates/examples/src/readobj/elf.rs Outdated
@philipc

philipc commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

For the purposes of this crate, is Architecture::Aarch64_Arm64e identical to Architecture::Aarch64 except for the Mach-O CPU subtype? My instinct is that we should add a method to write::Object to set the Mach-O CPU subtype instead of adding a new Architecture variant for this.

@arttet arttet requested review from bjorn3 and philipc August 31, 2023 11:16
@arttet arttet marked this pull request as ready for review August 31, 2023 11:17
philipc
philipc requested changes Aug 31, 2023
View reviewed changes
Comment thread src/write/macho.rs Outdated
Comment thread src/write/macho.rs Outdated
Comment thread src/write/mod.rs Outdated
@arttet arttet requested a review from philipc August 31, 2023 12:39
@arttet

arttet commented Sep 1, 2023

Copy link
Copy Markdown
Contributor Author

Can we merge it?

P.S. rust-lang/rust#115218

@philipc philipc merged commit 4980fdc into gimli-rs:master Sep 3, 2023
@philipc

philipc commented Sep 3, 2023

Copy link
Copy Markdown
Contributor

Published in 0.32.1

mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
@arttet
write/macho: Support the arm64e architecture for macOS/iOS (gimli-rs#574
6fd8ee8 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipc philipc philipc approved these changes

@bjorn3 bjorn3 Awaiting requested review from bjorn3

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support the arm64e architecture for macOS/iOS

3 participants

@arttet @philipc @bjorn3