elf: allow unaligned compression headers#236
Merged
philipc merged 1 commit intogimli-rs:masterfrom Jun 15, 2020
Merged
Conversation
Compressed sections are commonly emitted with the wrong alignment. This has been fixed in more recent versions of the major compilers, but for now let's support the invalid alignment even with the unaligned feature disabled, since performance here doesn't matter much.
mcbegamerxx954
pushed a commit
to mcbegamerxx954/object
that referenced
this pull request
Jun 15, 2024
elf: allow unaligned compression headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compressed sections are commonly emitted with the wrong alignment. This has been fixed in more recent versions of the major compilers, but for now let's support the invalid alignment even with the
unaligned feature disabled, since performance here doesn't matter much.
Fixes #235