Skip to content

Fix URL links on README.rst#135

Merged
Mariatta merged 4 commits intogidgethub:masterfrom
marcelotrevisani:patch-1
Nov 25, 2020
Merged

Fix URL links on README.rst#135
Mariatta merged 4 commits intogidgethub:masterfrom
marcelotrevisani:patch-1

Conversation

@marcelotrevisani
Copy link
Copy Markdown
Contributor

No description provided.

Fix URL links to the GitHub API on the README.rst.
@marcelotrevisani marcelotrevisani changed the title Fix URL links Fix URL links on README.rst Nov 10, 2020
Copy link
Copy Markdown
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I checked the links and confirmed that the new urls are more up to date.

@Mariatta
Copy link
Copy Markdown
Member

Ah but the CI failed somehow. Please check the errors and ensure builds are passing.

Copy link
Copy Markdown
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcelotrevisani
Copy link
Copy Markdown
Contributor Author

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 12, 2020

Codecov Report

Merging #135 (475a983) into master (27c104d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          395       397    +2     
  Branches        74        74           
=========================================
+ Hits           395       397    +2     
Impacted Files Coverage Δ
gidgethub/routing.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c104d...475a983. Read the comment docs.

Comment thread README.rst Outdated
Co-authored-by: Brett Cannon <[email protected]>
Comment thread README.rst Outdated
@brettcannon brettcannon requested a review from Mariatta November 25, 2020 00:13
Copy link
Copy Markdown
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mariatta Mariatta merged commit 0c2972a into gidgethub:master Nov 25, 2020
@marcelotrevisani marcelotrevisani deleted the patch-1 branch November 25, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants