Skip to content

Add a way to fetch the functions for a given event on a router#134

Merged
brettcannon merged 17 commits intogidgethub:masterfrom
dhruvmanila:feature/routing
Nov 20, 2020
Merged

Add a way to fetch the functions for a given event on a router#134
brettcannon merged 17 commits intogidgethub:masterfrom
dhruvmanila:feature/routing

Conversation

@dhruvmanila
Copy link
Copy Markdown
Contributor

@dhruvmanila dhruvmanila commented Nov 7, 2020

Closes #74
Closes #133

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 7, 2020

Codecov Report

Merging #134 (45b8891) into master (27c104d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          395       397    +2     
  Branches        74        74           
=========================================
+ Hits           395       397    +2     
Impacted Files Coverage Δ
gidgethub/httpx.py 100.00% <ø> (ø)
gidgethub/routing.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c104d...45b8891. Read the comment docs.

@dhruvmanila
Copy link
Copy Markdown
Contributor Author

As mentioned in #133 mypy tests are failing due to an incorrect type.

@brettcannon brettcannon self-requested a review November 9, 2020 22:44
Comment thread gidgethub/httpx.py
Comment thread gidgethub/routing.py
Comment thread gidgethub/routing.py Outdated
Comment thread tests/test_routing.py Outdated
Comment thread tests/test_routing.py Outdated
Comment thread tests/test_routing.py
Comment thread docs/routing.rst Outdated
@Mariatta
Copy link
Copy Markdown
Member

@Mariatta Mariatta mentioned this pull request Nov 10, 2020
@dhruvmanila
Copy link
Copy Markdown
Contributor Author

Also, I want to say thank you to @Mariatta for creating the GitHub app tutorial. Due to Hacktoberfest, we received more than 1,000 pull requests in https://github.com/TheAlgorithms/Python out of which half were invalid. So I went out to look for automation and found this tutorial.

I created this bot and right now it is in the process of getting approved and will soon be deployed in the repository. This will help us focus on the algorithms part and delegate the low level tasks to the bot.

Comment thread tests/test_routing.py Outdated
Comment thread tests/test_routing.py Outdated
Comment thread docs/changelog.rst
@brettcannon brettcannon merged commit 63250a5 into gidgethub:master Nov 20, 2020
@dhruvmanila
Copy link
Copy Markdown
Contributor Author

Thank you for all your guidance throughout this pull request and for merging this! 😁

@dhruvmanila dhruvmanila deleted the feature/routing branch November 21, 2020 04:50
@brettcannon
Copy link
Copy Markdown
Collaborator

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mypy] Incorrect type for argument data to httpx.AsyncClient.request Provide a way to fetch the functions for a given event on a router

3 participants