You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b1d759c
Browse filesBrowse the repository at this point in the historyBrowse files
Fail an actor whose image the registry refuses instead of resuming it forever
An ActorTemplate whose container image does not exist — a digest the
registry answers 404 for, a private repository the pull is not allowed
to read — never boots and is never reported: atelet's pull fails with
the registry's answer, the Run/Restore RPC returns it untagged, ate-api
treats the resume error as transient, and the ActorTemplate reconciler
requeues the golden boot with backoff. The template's golden snapshot
status stays empty forever, so a consumer watching it (kagent reports
`Ready=False ActorTemplatePending`) cannot tell a slow boot from a
misconfigured image, and every attempt pins a worker to the golden
actor.
Classify the registry's final word where the typed error is available.
The image cache tags a *transport.Error whose HTTP status is a client
error other than a timeout (408) or a throttle (429) with
ateerrors.ReasonFailedGetExternalObject — the Reason the object storage
clients already put on a missing snapshot object. The status decides,
not the body's error code: a registry may answer a missing manifest
with UNKNOWN, or a definitive 403 with a code the transport deems
temporary. A 5xx, a 429 the transport's retry did not outlast,
connection trouble, local cache I/O and a canceled pull pass through
untagged and stay retriable.
The Run and Restore boundaries claim that Reason next to
ReasonInvalidContainerConfig, so ate-api crashes the actor and releases
its worker. maybeCrashActor now returns the crash with its cause and
the directive still attached, and the ActorTemplate reconciler, when
the resume itself reports the crash, fails the template at once with
that message (`GoldenActorCrashed: actor ate-golden/<uid> crashed: ...
MANIFEST_UNKNOWN: manifest unknown`) instead of observing CRASHED on
the retry without it.
Tests: the classification table and a real-registry pull (a missing tag
and a missing digest come back tagged with the registry's answer kept
in the chain; a registry that only answers 503 does not), the tag
through prepareOCIDirectory and the boundary's claim, maybeCrashActor's
returned error, and the reconciler failing a template on a resume that
crashed the golden actor.
Related: agent-substrate#1220 proposes to crash actors on
every failure not marked retriable and classifies registry answers on
the way; this change is the narrow, status-based classification of the
one class that is a registry's final word, and applies on its own.
0 commit comments