Skip to content

feat(chart): stop rendering spec.context.compaction on the AgentTemplate - #41

Merged
QuentinBisson merged 3 commits into
mainfrom
fix/no-agenttemplate-compaction
Sep 24, 2026
Merged

QuentinBisson merged 3 commits into
mainfrom
fix/no-agenttemplate-compaction

Conversation

@QuentinBisson

Copy link
Copy Markdown
Contributor

Problem

kagent-dev/kagent#2790 moved context compaction from the AgentTemplate to Harness.spec.kagent.compaction. The kagent line from 1.1.0 (giantswarm/giantswarm#37705) has no spec.context on the AgentTemplate and refuses a template that carries it at admission, so every agent HelmRelease from this chart fails to install there; agentlab's agents-test shows it.

Change

The chart renders no spec.context any more. The context.compaction values stay accepted, for the values of existing releases, and render nothing; the platform Harness carries the compaction for every admitted agent (agent-platform kagent.harness.compaction, the same defaults this chart used to render). Unit tests, the ATS smoke assertions and the README follow.

@circleci-architect

circleci-architect Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Published Helm chart agent

1.4.4-r2c5463b5t20260924092522h7d7c768
Chart agent
Version 1.4.4-r2c5463b5t20260924092522h7d7c768
OCI reference oci://gsoci.azurecr.io/charts/giantswarm/agent:1.4.4-r2c5463b5t20260924092522h7d7c768
Digest sha256:8e625c716eb5e2038a564003a9aec3033f18a58d77b919407e5d4cf04db2708a
Registry public — gsoci.azurecr.io
Git catalog giantswarm-test-catalog (index)
Pull this chart
helm pull oci://gsoci.azurecr.io/charts/giantswarm/agent --version 1.4.4-r2c5463b5t20260924092522h7d7c768

Posted by architect-orb · build 431 · commit 7d7c768 · updated in place on every push

kagent-dev/kagent#2790 moved context compaction to
Harness.spec.kagent.compaction. The kagent line from 1.1.0 has no
spec.context on the AgentTemplate and refuses a template that carries it,
so the agent's HelmRelease never installed. The platform Harness carries
the compaction for every admitted agent; the context.compaction values
stay accepted for existing releases and render nothing.
@QuentinBisson
QuentinBisson force-pushed the fix/no-agenttemplate-compaction branch from b638a67 to a60da3f Compare September 24, 2026 09:18
@QuentinBisson

Copy link
Copy Markdown
Contributor Author

Proof on agentlab (2026-09-24, kagent 1.1 line dev build 0.9.11-r588f3d76t20260924141400h1f36e2c, Substrate v0.2.0-beta5 line, agent-platform branch repin/kagent-substrate-1-1 with kagent.harness.compaction): agent-manager at this branch's dev build 1.4.4-r2c5463b5t20260924092522h7d7c768 created an agent that reached Ready on the platform Harness, whose spec.kagent.compaction is {eventRetentionSize: 4, tokenThreshold: 24000}; agents-test 6/6 and a2a-test 5/5 with the fixtures on the same chart. The 1.4.4 release, which still renders spec.context, is refused by that kagent (.spec.context: field not declared in schema), so the 1.0 fleet must stop floating before this merges: giantswarm/agent-platform#668 caps agent-manager.agentChart.semver at >=1.0.0 <1.5.0; agentlab#272 lets the proofs accept the cap. Merge order: #668 released → this → #665 with >=1.5.0 <2.0.0.

QuentinBisson added a commit to giantswarm/agent-platform that referenced this pull request Sep 24, 2026
* fix(agent-manager): cap the Generic agent chart below 1.5.0

Generic agent chart 1.5.0 (giantswarm/agent#41) renders no spec.context.compaction on the AgentTemplate: the kagent line from 1.1.0 refuses the field and the platform Harness carries the compaction there. The kagent 1.0 line this release delivers has no other place for it, so agent-manager.agentChart.semver is >=1.0.0 <1.5.0 until the meta chart moves to the 1.1 lines.

* test(target): hold the agent chart cap in the golden comparison

* test(ats): the smoke expects the capped agent chart range
@QuentinBisson
QuentinBisson marked this pull request as ready for review September 24, 2026 20:49
@QuentinBisson
QuentinBisson requested a review from a team as a code owner September 24, 2026 20:49
@QuentinBisson
QuentinBisson merged commit a64eaeb into main Sep 24, 2026
7 of 8 checks passed
@QuentinBisson
QuentinBisson deleted the fix/no-agenttemplate-compaction branch September 24, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant