Conversation
fed0781 to
d3e7b18
Compare
setup.py
Outdated
There was a problem hiding this comment.
Why this? AFAIK setuptools is a third-party dep which is not installed by default.
There was a problem hiding this comment.
pip requires setuptools if installing from source. Wheels do not use the setup.py script. Both 'bootstrapped' in 2.7 & 3.4.
There was a problem hiding this comment.
I'm eager to do this only if a brand new Python installation (2.6 included) has setuptools installed.
|
Thanks for writing this. The changes you did against the import system broke some imports on Python 3 though: |
setup.py
Outdated
There was a problem hiding this comment.
According to this:
https://pythonhosted.org/setuptools/setuptools.html#setting-the-zip-safe-flag
...zip_safe=False seems to be unnecessary because if the package contains C extension files (as psutil) zip_safe is already implicitly set to False. Given that zip_safe is an option which exists only if setuptools is installed I think it makes sense to remove it.
|
Also, once you manage to fix the imports don't forget to update README.rst and CREDITS.rst (add your name). |
|
I'm looking into the import failure on py 3.x. |
|
Yes, the import failure is because of the different names in setup.py. For example, in |
9d52300 to
b33ad4c
Compare
|
finally fixed the tests. |
b33ad4c to
4307c28
Compare
|
I dropped the setuptools stuff. |
There was a problem hiding this comment.
Please don't do this for now. I'll think about whether I'm OK with this later.
|
I made different commits today and this PR cannot be merged cleanly anymore. For some reason the py modules can be imported, as in: ...but the C extension modules are not found: |
|
Note: travis tests pass so it seems to be a problem related with tox: |
|
OK, I solved the issue by adding "usedevelop = True" in the tox config file. I merged your PR as of |
|
Unfortunately I had to revert this change in 454b1ac because relative imports no longer works if I run the interactive interpreter from within psutil installation directory. |
|
Why on earth would you do that? Open an interactive interpreter a package and access the package?! And even if you must have this why revert the module move? You could have reverted only the relative imports. |
|
Well, when I work on psutil I have a shell open in psutil root directory so it's not rare I open up a python interpreter in order to try some stuff. I also sometimes executes scripts (import psutil) from within the root directory and the same issue occurs. I also reverted the changes in setup.py because the same problem applies. |
No description provided.